Pen+ V6 #535

David-Orangemoon · 2023-06-05T04:52:48Z

A massive rewrite of the extension no longer compatible so it is a different file to allow use of the old one.

Maybe closes #170

Closes #226

David-Orangemoon · 2023-06-28T01:15:21Z

The roster of the update.

yuri-kiss · 2023-06-28T04:40:01Z

did you ever fix the image stamping issue

David-Orangemoon · 2023-06-28T18:19:12Z

did you ever fix the image stamping issue

?

yuri-kiss · 2023-06-28T19:14:56Z

did you ever fix the image stamping issue

?

David-Orangemoon · 2023-06-28T19:27:28Z

did you ever fix the image stamping issue

?

Oh yeah this version of pen+ works completely differently.

yuri-kiss · 2023-06-28T19:28:53Z

Ya!

David-Orangemoon · 2023-07-01T00:38:28Z

Celebrating 1 month in pull request LIMBO!

TheShovel · 2023-07-01T00:39:42Z

Woooo! Let's go!

PuzzlingGGG · 2023-07-02T00:39:29Z

yay!!!!

David-Orangemoon · 2023-07-13T18:20:23Z

Also updated extension builder

tigercoding56 · 2023-07-23T21:48:53Z

can you add a way to render polygons from a list of 2d coordinates ?

David-Orangemoon · 2023-07-23T22:05:18Z

You can just iterate through the list.

…

On Sun, Jul 23, 2023, 5:49 PM tigercoding56 ***@***.***> wrote: can you add a way to render polygons from a list of 2d coordinates ? — Reply to this email directly, view it on GitHub <#535 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASKLQSJHKJDW3FQYADH42TLXRWL5BANCNFSM6AAAAAAY2NYNTY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

tigercoding56 · 2023-07-24T03:18:42Z

You can just iterate through the list.
…
On Sun, Jul 23, 2023, 5:49 PM tigercoding56 @.> wrote: can you add a way to render polygons from a list of 2d coordinates ? — Reply to this email directly, view it on GitHub <#535 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASKLQSJHKJDW3FQYADH42TLXRWL5BANCNFSM6AAAAAAY2NYNTY . You are receiving this because you authored the thread.Message ID: @.>

that is slow AF , not to mention how slow filling it in is

David-Orangemoon · 2023-07-24T05:10:27Z

You can just iterate through the list.
…
On Sun, Jul 23, 2023, 5:49 PM tigercoding56 @.> wrote: can you add a way to render polygons from a list of 2d coordinates ? — Reply to this email directly, view it on GitHub <#535 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASKLQSJHKJDW3FQYADH42TLXRWL5BANCNFSM6AAAAAAY2NYNTY . You are receiving this because you authored the thread.Message ID: _@**.**_>

that is slow AF , not to mention how slow filling it in is

How are you filling them in?

David-Orangemoon · 2023-07-24T05:22:26Z

You can just iterate through the list.
…
On Sun, Jul 23, 2023, 5:49 PM tigercoding56 @.> wrote: can you add a way to render polygons from a list of 2d coordinates ? — Reply to this email directly, view it on GitHub <#535 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASKLQSJHKJDW3FQYADH42TLXRWL5BANCNFSM6AAAAAAY2NYNTY . You are receiving this because you authored the thread.Message ID: _@**.**_>

that is slow AF , not to mention how slow filling it in is

Also what version of pen+ are you running?

skyistumbling · 2023-08-06T06:02:58Z

we need this now

LilyMakesThings · 2023-08-10T02:44:46Z

thank you for fixing all menus

David-Orangemoon · 2023-08-10T03:46:49Z

thank you for fixing all menus

get good

Samq64

The docs allow using scratchbocks so all the images and CSS aren't necessary anymore.

I can't fully review this because it's a lot of code but also because I'm not very familiar with WebGL.

extensions/obviousAlexC/SensingPlus.js

extensions/obviousAlexC/penPlus.js

David-Orangemoon · 2023-08-19T17:00:42Z

Ok

…

On Sat, Aug 19, 2023, 12:37 PM LilyMakesThings ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In extensions/obviousAlexC/penPlus.js <#535 (comment)>: > +//Thanks + +/* A message to contributers + +I ask of you one very simple thing. Do not try to add anything to pen+ if you don't know webgl. +Though this may come off as rude. +*/ + +(function (Scratch) { + "use strict"; + + //?Note to garboMuffin I use this class called "ExtensionBuilder" that I made to make the workflow faster so I don't have to spend as much time checking and modifying JSON data. + //?Also I really like the syntax compared to JSON. + + /* eslint-disable */ + class ExtensionBuilder{constructor(t,n,i,e){this.internal={},this.internal.JSON={blocks:[],menus:{}},this.runtime=Scratch.vm.runtime,this.internal.defaultFunction={code(){console.log("This block has no code")},arguments:{}},this.addDocs=t=>{this.internal.JSON.docsURI=t},this.addBlock=(t,n,i,e,l,s)=>{e=e||this.internal.defaultFunction.code,this[n]=e,s=s||{};let o=s;o.disableMonitor||(o.disableMonitor=!0),o.opcode=n,o.blockType=i,o.text=t,o.arguments=l||JSON.parse(JSON.stringify(this.internal.defaultFunction.arguments));let r=this.internal.JSON.blocks.length;return this.internal.JSON.blocks.push(o),this.internal.JSON.blocks[r].addArgument=(t,i,e,l)=>{if(null==(e=e||null))switch(typeof i){case"string":default:e=Scratch.ArgumentType.STRING;break;case"boolean":e=Scratch.ArgumentType.BOOLEAN;break;case"number":case"bigint":e=Scratch.ArgumentType.NUMBER}return null==i?this.internal.JSON.blocks[r].arguments[t]={type:e}:this.internal.JSON.blocks[r].arguments[t]={type:e,defaultValue:i},(l=l||null)&&("string"==typeof l?this.internal.JSON.blocks[r].arguments[t].menu=l:"function"==typeof l||"object"==typeof l?(this.addMenu(n+"_"+t+"_Menu",l,!0),this.internal.JSON.blocks[r].arguments[t].menu=n+"_"+t+"_Menu"):console.error("Menu '"+n+"_"+t+"_Menu'is not valid!")),this.internal.JSON.blocks[r]},this.internal.JSON.blocks[r].setIcon=t=>(this.internal.JSON.blocks[r].blockIconURI=t,this.internal.JSON.blocks[r]),this.internal.JSON.blocks[r].setFilter=t=>(t=t||Scratch.TargetType.SPRITE,this.internal.JSON.blocks[r].filter=t,this.internal.JSON.blocks[r]),this.internal.JSON.blocks[r].hideBlock=()=>(this.internal.JSON.blocks[r].hideFromPalette=!0,this.internal.JSON.blocks[r]),this.internal.JSON.blocks[r].stopMoniter=()=>(this.internal.JSON.blocks[r].disableMonitor=!0,this.internal.JSON.blocks[r]),this.internal.JSON.blocks[r].setEdgeActivation=t=>(this.internal.JSON.blocks[r].isEdgeActivated=t,this.internal.JSON.blocks[r]),this.internal.JSON.blocks[r].addImage=(t,n,i)=>{i=i||!1;let e={type:Scratch.ArgumentType.IMAGE,dataURI:n,flipRTL:i};return this.internal.JSON.blocks[r].arguments[t]=e,this.internal.JSON.blocks[r]},this.internal.JSON.blocks[r]},this.addMenu=(t,n,i)=>{i=i||!1,"function"==typeof n?(this[t+"Function"]=n,this.internal.JSON.menus[t]={items:t+"Function"}):this.internal.JSON.menus[t]={items:n},this.internal.JSON.menus[t].acceptReporters=i},this.addButton=(t,n,i)=>{n=n||this.internal.defaultFunction.code,i=i||"Button",this["button_"+t]=n;let e={};e.func="button_"+t,e.blockType=Scratch.BlockType.BUTTON,e.text=i;let l=this.internal.JSON.blocks.length;return this.internal.JSON.blocks[l]=e,this.internal.JSON.blocks[l]},this.addDivider=()=>{this.internal.JSON.blocks.push("---")},this.addLabel=t=>{t=t||"N/A";let n={opcode:"__NOUSEOPCODE",blockType:"label",text:t};this.internal.JSON.blocks.push(n)},this.__NOUSEOPCODE=()=>{},this.internal.createBase=()=>{if(t=t||"Extension",n=n||"extension",this.internal.JSON.name=t,this.internal.JSON.id=n,(i=i||{}).blockColor=i.blockColor||null,i.inputColor=i.inputColor||null,i.outlineColor=i.outlineColor||null,null!=i.blockColor){let l=i.blockColor;l>8947848?this.internal.colors=[l,l-197379,l-394758,]:this.internal.colors=[l,l+197379,l+394758,],i.inputColor,this.internal.colors[1]=i.inputColor,i.outlineColor,this.internal.colors[2]=i.outlineColor,this.internal.JSON.color1=this.internal.colors[0],this.internal.JSON.color2=this.internal.colors[1],this.internal.JSON.color3=this.internal.colors[2]}(e=e||{}).blockIconUri=e.blockIconUri||null,e.menuIconUri=e.menuIconUri||e.blockIconUri||null,this.menuUri=e.menuIconUri,this.blockIco=e.blockIconUri,this.docsUri=null},this.internal.createBase(),this.setColors=(t,n,i)=>{t="string"==typeof t?t:(t+0).toString(16),n="string"==typeof n?n:(n+0).toString(16),i="string"==typeof i?i:(i+0).toString(16),this.internal.colors=[0,0,0],this.internal.colors[0]=t,this.internal.colors[1]=n,this.internal.colors[2]=i,this.internal.JSON.color1=t,this.internal.JSON.color2=n,this.internal.JSON.color3=i},this.setMenuIcon=t=>{this.internal.JSON.menuIconURI=t},this.setGlobalBlockIcon=t=>{this.internal.JSON.blockIconURI=t},this.runHat=t=>{this.runtime.startHats(this.internal.JSON.id+"_"+t)},this.getInfo=()=>this.internal.JSON,this.register=()=>{Scratch.extensions.register(this)}}} it's minified code, this is normal — Reply to this email directly, view it on GitHub <#535 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASKLQSKGX4I5BT3XDMIVALLXWDTTZANCNFSM6AAAAAAY2NYNTY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

David-Orangemoon · 2023-08-19T17:05:18Z

I've gotten nothing in the browser so it's probably nothing to worry about

…

On Sat, Aug 19, 2023, 1:03 PM Samq64 ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In extensions/obviousAlexC/penPlus.js <#535 (comment)>: > +//Thanks + +/* A message to contributers + +I ask of you one very simple thing. Do not try to add anything to pen+ if you don't know webgl. +Though this may come off as rude. +*/ + +(function (Scratch) { + "use strict"; + + //?Note to garboMuffin I use this class called "ExtensionBuilder" that I made to make the workflow faster so I don't have to spend as much time checking and modifying JSON data. + //?Also I really like the syntax compared to JSON. + + /* eslint-disable */ + class ExtensionBuilder{constructor(t,n,i,e){this.internal={},this.internal.JSON={blocks:[],menus:{}},this.runtime=Scratch.vm.runtime,this.internal.defaultFunction={code(){console.log("This block has no code")},arguments:{}},this.addDocs=t=>{this.internal.JSON.docsURI=t},this.addBlock=(t,n,i,e,l,s)=>{e=e||this.internal.defaultFunction.code,this[n]=e,s=s||{};let o=s;o.disableMonitor||(o.disableMonitor=!0),o.opcode=n,o.blockType=i,o.text=t,o.arguments=l||JSON.parse(JSON.stringify(this.internal.defaultFunction.arguments));let r=this.internal.JSON.blocks.length;return this.internal.JSON.blocks.push(o),this.internal.JSON.blocks[r].addArgument=(t,i,e,l)=>{if(null==(e=e||null))switch(typeof i){case"string":default:e=Scratch.ArgumentType.STRING;break;case"boolean":e=Scratch.ArgumentType.BOOLEAN;break;case"number":case"bigint":e=Scratch.ArgumentType.NUMBER}return null==i?this.internal.JSON.blocks[r].arguments[t]={type:e}:this.internal.JSON.blocks[r].arguments[t]={type:e,defaultValue:i},(l=l||null)&&("string"==typeof l?this.internal.JSON.blocks[r].arguments[t].menu=l:"function"==typeof l||"object"==typeof l?(this.addMenu(n+"_"+t+"_Menu",l,!0),this.internal.JSON.blocks[r].arguments[t].menu=n+"_"+t+"_Menu"):console.error("Menu '"+n+"_"+t+"_Menu'is not valid!")),this.internal.JSON.blocks[r]},this.internal.JSON.blocks[r].setIcon=t=>(this.internal.JSON.blocks[r].blockIconURI=t,this.internal.JSON.blocks[r]),this.internal.JSON.blocks[r].setFilter=t=>(t=t||Scratch.TargetType.SPRITE,this.internal.JSON.blocks[r].filter=t,this.internal.JSON.blocks[r]),this.internal.JSON.blocks[r].hideBlock=()=>(this.internal.JSON.blocks[r].hideFromPalette=!0,this.internal.JSON.blocks[r]),this.internal.JSON.blocks[r].stopMoniter=()=>(this.internal.JSON.blocks[r].disableMonitor=!0,this.internal.JSON.blocks[r]),this.internal.JSON.blocks[r].setEdgeActivation=t=>(this.internal.JSON.blocks[r].isEdgeActivated=t,this.internal.JSON.blocks[r]),this.internal.JSON.blocks[r].addImage=(t,n,i)=>{i=i||!1;let e={type:Scratch.ArgumentType.IMAGE,dataURI:n,flipRTL:i};return this.internal.JSON.blocks[r].arguments[t]=e,this.internal.JSON.blocks[r]},this.internal.JSON.blocks[r]},this.addMenu=(t,n,i)=>{i=i||!1,"function"==typeof n?(this[t+"Function"]=n,this.internal.JSON.menus[t]={items:t+"Function"}):this.internal.JSON.menus[t]={items:n},this.internal.JSON.menus[t].acceptReporters=i},this.addButton=(t,n,i)=>{n=n||this.internal.defaultFunction.code,i=i||"Button",this["button_"+t]=n;let e={};e.func="button_"+t,e.blockType=Scratch.BlockType.BUTTON,e.text=i;let l=this.internal.JSON.blocks.length;return this.internal.JSON.blocks[l]=e,this.internal.JSON.blocks[l]},this.addDivider=()=>{this.internal.JSON.blocks.push("---")},this.addLabel=t=>{t=t||"N/A";let n={opcode:"__NOUSEOPCODE",blockType:"label",text:t};this.internal.JSON.blocks.push(n)},this.__NOUSEOPCODE=()=>{},this.internal.createBase=()=>{if(t=t||"Extension",n=n||"extension",this.internal.JSON.name=t,this.internal.JSON.id=n,(i=i||{}).blockColor=i.blockColor||null,i.inputColor=i.inputColor||null,i.outlineColor=i.outlineColor||null,null!=i.blockColor){let l=i.blockColor;l>8947848?this.internal.colors=[l,l-197379,l-394758,]:this.internal.colors=[l,l+197379,l+394758,],i.inputColor,this.internal.colors[1]=i.inputColor,i.outlineColor,this.internal.colors[2]=i.outlineColor,this.internal.JSON.color1=this.internal.colors[0],this.internal.JSON.color2=this.internal.colors[1],this.internal.JSON.color3=this.internal.colors[2]}(e=e||{}).blockIconUri=e.blockIconUri||null,e.menuIconUri=e.menuIconUri||e.blockIconUri||null,this.menuUri=e.menuIconUri,this.blockIco=e.blockIconUri,this.docsUri=null},this.internal.createBase(),this.setColors=(t,n,i)=>{t="string"==typeof t?t:(t+0).toString(16),n="string"==typeof n?n:(n+0).toString(16),i="string"==typeof i?i:(i+0).toString(16),this.internal.colors=[0,0,0],this.internal.colors[0]=t,this.internal.colors[1]=n,this.internal.colors[2]=i,this.internal.JSON.color1=t,this.internal.JSON.color2=n,this.internal.JSON.color3=i},this.setMenuIcon=t=>{this.internal.JSON.menuIconURI=t},this.setGlobalBlockIcon=t=>{this.internal.JSON.blockIconURI=t},this.runHat=t=>{this.runtime.startHats(this.internal.JSON.id+"_"+t)},this.getInfo=()=>this.internal.JSON,this.register=()=>{Scratch.extensions.register(this)}}} You're right. VSCode does think there are a couple errors on that line though. — Reply to this email directly, view it on GitHub <#535 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASKLQSOO35A6BLTLYLH65V3XWDWVRANCNFSM6AAAAAAY2NYNTY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

GarboMuffin

Realistically I will never be able to give this a full proper review

I left some comments

Some other feedback:

scratch-render has a "render regions" system that they use to make sure the right buffers are bound at the right time and not a moment sooner. I think you should try using that system instead of haphazard buffer binding
you might want to consider just completely replacing the pen skin honestly. As-is this extension's existence means that PenSkin.js basically can't be touched anymore. That's not ideal.

extensions/obviousAlexC/penPlus.js

GarboMuffin · 2023-08-22T21:03:27Z

also, lowercase "Get pen square's [Width v]"

David-Orangemoon · 2023-08-22T21:12:39Z

Realistically I will never be able to give this a full proper review

I left some comments

Some other feedback:

scratch-render has a "render regions" system that they use to make sure the right buffers are bound at the right time and not a moment sooner. I think you should try using that system instead of haphazard buffer binding

you might want to consider just completely replacing the pen skin honestly. As-is this extension's existence means that PenSkin.js basically can't be touched anymore. That's not ideal.

The thing with replacing penSkin.js is that it would no longer be compatiable with the scratch pen which I'm trying to make it compatible with.

David-Orangemoon · 2023-08-22T21:25:34Z

also there's a menu with acceptReporters: false to reconsider

Sorry that is an artifact from the ExtensionBuilder compiler I'll fix that.

David-Orangemoon · 2023-08-22T21:31:54Z

Realistically I will never be able to give this a full proper review

I left some comments

Some other feedback:

scratch-render has a "render regions" system that they use to make sure the right buffers are bound at the right time and not a moment sooner. I think you should try using that system instead of haphazard buffer binding

you might want to consider just completely replacing the pen skin honestly. As-is this extension's existence means that PenSkin.js basically can't be touched anymore. That's not ideal.

Garbo do you mean draw regions when you say render regions?

GarboMuffin · 2023-08-25T23:54:30Z

do you consider this done?

GarboMuffin · 2023-08-25T23:54:42Z

Aside from the one minor gripe ESLint has

David-Orangemoon · 2023-08-26T00:16:54Z

Yes just give me a little bit to grt home I have a version with some minor changes

…

On Fri, Aug 25, 2023, 7:54 PM GarboMuffin ***@***.***> wrote: Aside from the one minor gripe ESLint has — Reply to this email directly, view it on GitHub <#535 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASKLQSNIM7Z66DUWJLYZHMDXXE3M3ANCNFSM6AAAAAAY2NYNTY> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

David-Orangemoon · 2023-08-27T00:10:33Z

Ok I need to get home and I will fix valuetoset errors

LilyMakesThings · 2023-08-27T01:03:06Z

Bro's magic, he actually passed eslint

considering style errors don't exist anymore, so long as your code actually does what it's supposed to, it should be fine now

David-Orangemoon · 2023-08-27T18:34:38Z

Fixed minor depth buffer mistake

AlexSchoolOH · 2023-10-04T15:46:27Z

I give up

CubesterYT · 2023-10-04T16:09:32Z

What 😭😭😭

AlexSchoolOH · 2023-10-04T17:05:29Z

What 😭😭😭

I'm not dealing with turbowarp anymore.

GarboMuffin · 2023-10-04T20:09:41Z

I get it, I really do

I will get this over the finish line for you one day, thanks for your contributions thus far

David-Orangemoon · 2023-10-30T03:04:45Z

Keeping this and Sensing+ V3 up due to them still having the possibility of being merged

CubesterYT · 2023-11-06T01:29:31Z

LETS GOOOOO!!

This was referenced Jul 17, 2023

Disable filtering Pen+ #338

Closed

Pen + Issues with transparency #197

Closed

Samq64 suggested changes Aug 19, 2023

View reviewed changes

David-Orangemoon closed this Aug 22, 2023

Fix errors in Pull

dbbd2c2

David-Orangemoon reopened this Aug 22, 2023

Update penPlus.js

cf73cad

GarboMuffin reviewed Aug 22, 2023

View reviewed changes

extensions/obviousAlexC/penPlus.js Outdated Show resolved Hide resolved

extensions/obviousAlexC/penPlus.js Show resolved Hide resolved

extensions/obviousAlexC/penPlus.js Show resolved Hide resolved

David-Orangemoon added 6 commits August 26, 2023 00:28

Final patch

bafc9dd

Update penPlus.js

de96126

Update penplus.js

924734c

Update penPlus.js

122ff91

Update penplus.js

b3289fe

Update penPlus.js

be438e7

David-Orangemoon added 2 commits August 26, 2023 20:56

Update penPlus.js

bbae196

Update penPlus.js

c905e6f

This comment was marked as spam.

Sign in to view

Fixes

c2e15d4

This comment was marked as spam.

Sign in to view

GarboMuffin added 3 commits November 5, 2023 17:56

I'm sorry for the delay!

1ad28cd

Update some block names

6ca51db

npm run format

3a65c23

GarboMuffin merged commit 182580b into TurboWarp:master Nov 6, 2023
3 checks passed

Pen+ V6 #535

Pen+ V6 #535

Conversation

David-Orangemoon commented Jun 5, 2023 • edited by GarboMuffin Loading

David-Orangemoon commented Jun 28, 2023

yuri-kiss commented Jun 28, 2023

David-Orangemoon commented Jun 28, 2023

yuri-kiss commented Jun 28, 2023 • edited Loading

David-Orangemoon commented Jun 28, 2023

yuri-kiss commented Jun 28, 2023

David-Orangemoon commented Jul 1, 2023

TheShovel commented Jul 1, 2023

PuzzlingGGG commented Jul 2, 2023

David-Orangemoon commented Jul 13, 2023

tigercoding56 commented Jul 23, 2023

David-Orangemoon commented Jul 23, 2023 via email

tigercoding56 commented Jul 24, 2023

David-Orangemoon commented Jul 24, 2023

David-Orangemoon commented Jul 24, 2023

skyistumbling commented Aug 6, 2023

LilyMakesThings commented Aug 10, 2023

David-Orangemoon commented Aug 10, 2023

Samq64 left a comment

Choose a reason for hiding this comment

David-Orangemoon commented Aug 19, 2023 via email

David-Orangemoon commented Aug 19, 2023 via email

GarboMuffin left a comment • edited Loading

Choose a reason for hiding this comment

GarboMuffin commented Aug 22, 2023

David-Orangemoon commented Aug 22, 2023

David-Orangemoon commented Aug 22, 2023

David-Orangemoon commented Aug 22, 2023

GarboMuffin commented Aug 25, 2023

GarboMuffin commented Aug 25, 2023

David-Orangemoon commented Aug 26, 2023 via email

David-Orangemoon commented Aug 27, 2023

This comment was marked as spam.

LilyMakesThings commented Aug 27, 2023

David-Orangemoon commented Aug 27, 2023

AlexSchoolOH commented Oct 4, 2023

CubesterYT commented Oct 4, 2023

This comment was marked as spam.

AlexSchoolOH commented Oct 4, 2023

GarboMuffin commented Oct 4, 2023

David-Orangemoon commented Oct 30, 2023

This comment was marked as spam.

CubesterYT commented Nov 6, 2023

David-Orangemoon commented Jun 5, 2023 •

edited by GarboMuffin

Loading

yuri-kiss commented Jun 28, 2023 •

edited

Loading

GarboMuffin left a comment •

edited

Loading