Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lily/ListTools #623

Merged
merged 43 commits into from
Feb 18, 2024
Merged

Conversation

LilyMakesThings
Copy link
Contributor

@LilyMakesThings LilyMakesThings commented Jun 22, 2023

image

@qxsck
Copy link
Contributor

qxsck commented Jun 22, 2023

暂时不要合并它。 图像

同样出于某种原因,虽然菜单确实适用于大多数块,但当您更改编辑目标时,某些块的值会随机重置。我想这是涡轮扭曲中的一个错误?

类似的拓展我做过,但是你的更棒!

@LilyMakesThings
Copy link
Contributor Author

暂时不要合并它。 图像
同样出于某种原因,虽然菜单确实适用于大多数块,但当您更改编辑目标时,某些块的值会随机重置。我想这是涡轮扭曲中的一个错误?

类似的拓展我做过,但是你的更棒!

what

@LilyMakesThings
Copy link
Contributor Author

The 3 blocks that don't save their menu values. I believe it might be to do with the fact there's 2 variable arguments.
image

@CST1229
Copy link
Contributor

CST1229 commented Jun 22, 2023

暂时不要合并它。 图像
同样出于某种原因,虽然菜单确实适用于大多数块,但当您更改编辑目标时,某些块的值会随机重置。我想这是涡轮扭曲中的一个错误?

类似的拓展我做过,但是你的更棒!

what

google translated:

Don't merge it yet. !image

Also for some reason, while the menu does work for most blocks, when you change the edit target some blocks' values reset randomly. I guess it's a bug in Turbo Twist?

I did similar extensions, but yours is even better!

(probably quoting your entire message)

@ghost
Copy link

ghost commented Jun 26, 2023

Hope this gets added soon

@LilyMakesThings
Copy link
Contributor Author

Thumbnail:
image

@idoinfactexist
Copy link

lists plus?

@yuri-kiss
Copy link
Contributor

olo

@LilyMakesThings
Copy link
Contributor Author

As much as I despise looking at this palette with open-menu inputs, the menus don't work without acceptReporters enabled for whatever reason and I want this to be as merge-ready as possible.

@Flappy25
Copy link

HOW DOES IT SORT SO FAST?? It sorted over 9999 random numbers from 1 to 9999 almost INSTANTLY!

@LilyMakesThings
Copy link
Contributor Author

That's a funny looking error

@LilyMakesThings
Copy link
Contributor Author

I do not have access to an SVG editor that can address the validation errors, should i just leave out the thumbnail?

@ghost
Copy link

ghost commented Jul 23, 2023

Congrats on merging Motion+!

@NexusKitten

This comment was marked as spam.

@LilyMakesThings
Copy link
Contributor Author

Congrats on merging Motion+!

Lily was not the creator of More Motion.

That notification had me excited for a second, you owe me an Arizona iced tea /j

@NexusKitten

This comment was marked as spam.

@LilyMakesThings
Copy link
Contributor Author

no excuses

plenty of reasons, actually, just have some patience

@yuri-kiss
Copy link
Contributor

yuri-kiss commented Oct 11, 2023 via email

@ghost
Copy link

ghost commented Oct 12, 2023

me? oh i have patience, but not for rude stuff like "Exactly but it's been months lol", especially when they have been told why

________________________________ From: LilyMakesThings @.> Sent: Tuesday, October 10, 2023 4:03 PM To: TurboWarp/extensions @.> Cc: Surv @.>; Comment @.> Subject: Re: [TurboWarp/extensions] List Tools: Add List Tools (PR #623) no excuses plenty of reasons, actually, just have some patience — Reply to this email directly, view it on GitHub<#623 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BAGGRIFLAARXHANRM5ALXMLX6WS2LAVCNFSM6AAAAAAZPUAMEWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJWGE2DCNZUHA. You are receiving this because you commented.Message ID: @.***>

I wasn't trying to be rude.

@Skyhigh173
Copy link
Contributor

why not accept reporters in list selection 😢

@BlueDome77
Copy link
Contributor

I think some people here need to be more patient when it comes to open source updates. I've seen so many comments on this repo about how updates are "never coming". It's like this for any open source project.

Exactly but it's been months lol

It's not like people are getting paid to do this...

@ghost
Copy link

ghost commented Nov 15, 2023

I think some people here need to be more patient when it comes to open source updates. I've seen so many comments on this repo about how updates are "never coming". It's like this for any open source project.

(Rude remark deleted)

It's not like people are getting paid to do this...

Umm, that was an old reply...

@BlueDome77
Copy link
Contributor

I think some people here need to be more patient when it comes to open source updates. I've seen so many comments on this repo about how updates are "never coming". It's like this for any open source project.

Exactly but it's been months lol

It's not like people are getting paid to do this...

Umm, that was an old reply...

...

@ghost
Copy link

ghost commented Nov 29, 2023

Has this been merged yet?

@yuri-kiss
Copy link
Contributor

no

@LilyMakesThings
Copy link
Contributor Author

do people still celebrate half-birthdays, because we've got a really fun one coming up

@ghost
Copy link

ghost commented Dec 13, 2023

do people still celebrate half-birthdays, because we've got a really fun one coming up

YES! It's gonna be merged!

@LilyMakesThings
Copy link
Contributor Author

do people still celebrate half-birthdays, because we've got a really fun one coming up

YES! It's gonna be merged!

Quite the opposite

@ghost
Copy link

ghost commented Dec 13, 2023

do people still celebrate half-birthdays, because we've got a really fun one coming up

YES! It's gonna be merged!

Quite the opposite

slowly frowns

@ghost
Copy link

ghost commented Dec 20, 2023

Can't wait for the 6 month anniversary, i guess

@mcnole25
Copy link

This is my new account, hopefully List Tools gets added soon. And I apologize for the rude remarks.

@GarboMuffin
Copy link
Member

i believe this was discussed before but is there a reason the menus are name-based instead of id-based?

@LilyMakesThings
Copy link
Contributor Author

i believe this was discussed before but is there a reason the menus are name-based instead of id-based?

To allow people to put stuff like join blocks or variables in the menus to determine where list goes (parity with the "var and list" extension, essentially)

Suffers from a similar problem to Asset Manager in that regard

@GarboMuffin
Copy link
Member

thanks

@mcnole25
Copy link

mcnole25 commented Jan 8, 2024

To everyone, I apologize for all the inconvenience my old account has caused.

@GarboMuffin GarboMuffin changed the title List Tools: Add List Tools Add Lily/ListTools Feb 18, 2024
@GarboMuffin GarboMuffin merged commit 4ad6d64 into TurboWarp:master Feb 18, 2024
3 checks passed
@LilyMakesThings
Copy link
Contributor Author

metal

@qxsck
Copy link
Contributor

qxsck commented Feb 18, 2024

Started processing extension additions?

@mcnole25
Copy link

YESSSSSSSS FINALLY

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.