Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Longman Dictionary extension #651

Closed
wants to merge 11 commits into from
Closed

Longman Dictionary extension #651

wants to merge 11 commits into from

Conversation

veggiecan0419
Copy link
Contributor

@veggiecan0419 veggiecan0419 commented Jun 28, 2023 •
edited
Loading

Ever needed to get the definitions of words in your projects?
If so, here it is.

@GarboMuffin
Copy link
Member

Icon works poorly in dark mode

image

You will need to handle fetch() errors and return a readable error message instead of letting it return undefined

@veggiecan0419
Copy link
Contributor Author

veggiecan0419 commented Jul 1, 2023 •
edited
Loading

Update details

  • icon now works in dark and light mode
  • fixed the fetch() errors
  • renamed 'definition of...' to 'primary definition of...'
  • added 'all definitions of [word] in the Longman Dictionary '
  • added credits to veggiecan0419

@veggiecan0419 veggiecan0419 deleted the branch TurboWarp:master July 26, 2023 01:02
@veggiecan0419 veggiecan0419 deleted the master branch July 26, 2023 01:02
@veggiecan0419 veggiecan0419 restored the master branch July 26, 2023 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@veggiecan0419 @GarboMuffin