Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Color Picker extension #666

Merged
merged 10 commits into from
Aug 26, 2023
Merged

Conversation

TheShovel
Copy link
Contributor

A extension that let's you access your system color picker.
image
image
image
image

@ghost
Copy link

ghost commented Jul 1, 2023

Nice :)

@ghost
Copy link

ghost commented Jul 1, 2023

AAAHHH 666!!!!!!!

@TheShovel
Copy link
Contributor Author

Wait! Don't push this yet! I found a way to position the color picker!
I'm going to implement it tomorrow. Going to draft this for now.

@yuri-kiss
Copy link
Contributor

Wait! Don't push this yet! I found a way to position the color picker! I'm going to implement it tomorrow. Going to draft this for now.

interesting..

@TheShovel TheShovel marked this pull request as draft July 2, 2023 01:04
@yuri-kiss
Copy link
Contributor

I have an idea, i think you should add a hex option.

@TheShovel
Copy link
Contributor Author

I have an idea, i think you should add a hex option.

I can't. This is the system color picker. Every OS has a different one. I can't modify that.

@TheShovel TheShovel marked this pull request as ready for review July 2, 2023 13:05
@TheShovel
Copy link
Contributor Author

TheShovel commented Jul 2, 2023

This method for position is quite hacky, but I couldn't find a better way.
If you have a better method, I would be more than happy for you to add it.

image

@yuri-kiss
Copy link
Contributor

like have a hex output, you could just turn the rgb into hex

@TheShovel
Copy link
Contributor Author

like have a hex output, you could just turn the rgb into hex

There is one already! Look at the pictures on the top!

@yuri-kiss
Copy link
Contributor

im dumb lol sorry for the inconvenience

@ghost
Copy link

ghost commented Jul 2, 2023

I use ChromeOS.
The moving color picker blocks do not work. And whenever I click a block other than "show color picker", the color picker disappears.

@TheShovel
Copy link
Contributor Author

I use ChromeOS. The moving color picker blocks do not work. And whenever I click a block other than "show color picker", the color picker disappears.

The color picker disappearing is normal behavior. The color picker not moving is odd. I am on Linux (Pop_OS) and it works fine.
Mind showing me the console after you set the position?

@ghost
Copy link

ghost commented Jul 2, 2023

How do you access the console?

@Flappy25
Copy link

Flappy25 commented Jul 2, 2023

How do you access the console?

If you don't know how to, then why are you here

@TheShovel
Copy link
Contributor Author

How do you access the console?

Press CTRL+SHIFT+i and it will bring up the inspect element menu. After that, click on the console tab.

@ghost
Copy link

ghost commented Jul 2, 2023

I can't click "Inspect" on TurboWarp. It darkens it off and does nothing when clicked.

@ghost
Copy link

ghost commented Jul 2, 2023

I also tried Ctrl-Shift-I and it did nothing.

@yuri-kiss
Copy link
Contributor

I also tried Ctrl-Shift-I and it did nothing.

have you tried fn+f12 or f12?

@ghost
Copy link

ghost commented Jul 2, 2023

I actually figured it out and it said nothing.

@yuri-kiss
Copy link
Contributor

weird

@ghost
Copy link

ghost commented Jul 2, 2023

I don't have "F12" on my keyboard, SurvExe1Pc!

@yuri-kiss
Copy link
Contributor

what, why?

@ghost
Copy link

ghost commented Jul 3, 2023

I have a Chromebook.

@ghost
Copy link

ghost commented Jul 3, 2023

Is this pull request popular because it's 666?

@yuri-kiss
Copy link
Contributor

idk, but aughhhhhhhhh chromebook is evillll

@ghost
Copy link

ghost commented Jul 3, 2023

No it's not! I had a bad one before Christmas 2022, but now I have a good one! Chromebooks are worth it!

@Flappy25
Copy link

Flappy25 commented Jul 3, 2023

idk, but aughhhhhhhhh chromebook is evillll

Yeah, all you need to do is jailbreak the Chromebook into Linux

@ghost
Copy link

ghost commented Jul 4, 2023

I can't!

@LilyMakesThings
Copy link
Contributor

Please can we take this conversation elsewhere, such as the issues or discussion pages :)

@BlueDome77
Copy link
Contributor

AAAHHH 666!!!!!!!

lol

@GarboMuffin
Copy link
Member

I will merge when the icon works better in light mode

image

@GarboMuffin GarboMuffin merged commit 01a6f2f into TurboWarp:master Aug 26, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants