-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified clipboard extension #667
Conversation
Nice extension! But the clipboard reporter isn't working, sadly.... |
they forgot to ask for permission to use the clipboard as well :/ |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Every other block works OK for me, except for the clipboard reporter. |
This comment was marked as spam.
This comment was marked as spam.
It's your responsibility to ask for the clipboard. Look at my recent ExtraUtilities pull to figure out how to do that. |
This comment was marked as spam.
This comment was marked as spam.
I don't mind the merge |
Do you talk about my extension? If yes i don't need to ask permission because in my code there is no permission check |
To comply with the other Clipboard blocks in the 3 existing extensions that support them, you need to ask for permission |
I don't really understand why, for me you just need to delet the line where you check the permissions... but you have more experience than me, i trust you |
Really glad both of our work didn't go to waste |
Update: I set dom.events.asyncClipboard.readText to true on Firefox and now the clipboard block finally works. |
The current "read clipboard" block was not very thought out. Browsers typically ignore it if you aren't in eg. a click event handler, but Scratch blocks don't run in click events. Usually it ends up working the first time (because you click on the permission button), but future attempts silently break. We will probably have to make that prompt appear each time to make the block somewhat workable. Would encourage using "when something is pasted" and "last pasted text" instead if possible as those will never require permission requests |
Two people made a clipboard extension, both with blocks the other didn't have, and so I decided it would be best just to merge the two and let the creators split the credit.
If any of the original creators have issues with this, please leave a comment on this PR and we can try to work something out.\