Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sound Expanded: Add Sound Expanded extension #672

Merged
merged 27 commits into from
Aug 25, 2023

Conversation

LilyMakesThings
Copy link
Contributor

@LilyMakesThings LilyMakesThings commented Jul 2, 2023

Sound Expanded is an extension that adds a few missing blocks from the Sound category.

This serves as a precursor to my next extension, Audio Engine.
image

@NexusKitten

This comment was marked as spam.

@LilyMakesThings LilyMakesThings marked this pull request as ready for review July 2, 2023 03:06
@AdamMady
Copy link

AdamMady commented Jul 2, 2023

this reminds me of when I tried to make a "while playing note {VAR} for {VAR} beats in the {VAR}th beat fade into note {VAR} for {VAR} beats" block (it went badly)

@UndermanReal
Copy link

isnt start sound on loop the same as start looping sound?

@LilyMakesThings
Copy link
Contributor Author

isnt start sound on loop the same as start looping sound?

"start looping ()" only works for sounds that are already playing.

@AdamMady
Copy link

AdamMady commented Jul 3, 2023

I have a good idea @LilyMakesThings how about you make a block where you could change the global volume of the project instead of changing each volume of each sprite one by one

@UndermanReal
Copy link

UndermanReal commented Jul 3, 2023

I have a good idea @LilyMakesThings how about you make a block where you could change the global volume of the project instead of changing each volume of each sprite one by one

and we could also have volume for specific sounds

@AdamMady
Copy link

AdamMady commented Jul 3, 2023

I think I'll have a go for both I have nothing better to do

@UndermanReal
Copy link

I also think adding a stop sounds in (sprite) would be very useful, and if it's used in clones, then it would stop all sounds in the clone.

@LilyMakesThings
Copy link
Contributor Author

Please look at the block palette before suggesting blocks

@AdamMady
Copy link

AdamMady commented Jul 6, 2023

I know this is a bit much for a simple extension but is it possible to do a record block? where it records using the microphone and saves it to be used

@BlueDome77
Copy link
Contributor

I know this is a bit much for a simple extension but is it possible to do a record block? where it records using the microphone and saves it to be used

There is an extension exactly for that! Find "Recording" in the list: https://github.com/BlueDome77/Turbowarp-Extension-List/blob/main/README.md

@BlueDome77
Copy link
Contributor

I think you should merge the Sound extension with this

@BlueDome77
Copy link
Contributor

Could you add these?

scratchblocks-2

@LilyMakesThings
Copy link
Contributor Author

Could you add these?

scratchblocks-2

No

@Drago-Cuven
Copy link

Could you add these?

scratchblocks-2

:c

@NexusKitten

This comment was marked as spam.

}

_getTargets() {
const spriteNames = [];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's avoid the same mistake as looks+. have the top value always be "myself" with value _myself_ and just list every sprite under it, and also add the stage (_stage_)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a script that does that for skins, I'll add that now

@GarboMuffin
Copy link
Member

the combination of "start sound [ ] on loop" and "start looping [ ]" is going to confuse many people

@LilyMakesThings LilyMakesThings changed the title Sound Expanded: Add Sound Expanded extension Sound Plus: Add Sound Plus extension Jul 17, 2023
@LilyMakesThings
Copy link
Contributor Author

If I add "while it's playing" or something to the end, would that work? or could I literally just remove it

maybe begin/end looping for []

That's the one I think

@LilyMakesThings LilyMakesThings changed the title Sound Plus: Add Sound Plus extension Sound Expanded: Add Sound Expanded extension Jul 18, 2023
@LilyMakesThings
Copy link
Contributor Author

Update: added project volume blocks. Works (mostly) with addons' volume slider.
image

@LilyMakesThings
Copy link
Contributor Author

LilyMakesThings commented Aug 14, 2023

I added an attribute for dataURIs so you can export the sound as a data uri.

I pretty much only did this for the Sound extension, as well as the Video extension.

@GarboMuffin
Copy link
Member

Also how does this compare to #756?

@LilyMakesThings
Copy link
Contributor Author

Also how does this compare to #756?

ultrasound appears to not work in line with the default sound category, rather on its own use of the web audio api - think audio engine, audiostream or tuneshark. the main purpose of this is no different to clones plus, looks plus, etc.

@GarboMuffin
Copy link
Member

done?

@LilyMakesThings
Copy link
Contributor Author

yes

@GarboMuffin GarboMuffin merged commit ba9cd6a into TurboWarp:master Aug 25, 2023
3 checks passed
@LilyMakesThings LilyMakesThings deleted the SoundExpanded branch August 26, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants