Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic image validation #688

Merged
merged 5 commits into from
Jul 4, 2023
Merged

Automatic image validation #688

merged 5 commits into from
Jul 4, 2023

Conversation

GarboMuffin
Copy link
Member

@GarboMuffin GarboMuffin commented Jul 4, 2023

  • Images must be exactly 2:1 aspect ratio
  • SVGs must not contain <text> (convert to path)

Anyone using local development server must run npm ci for it to work properly after applying this

/images/clouddata-ping.svg: Error: Aspect ratio must be exactly 2, but found 2.0127 (159x79)
/images/godslayerakp/http.png: Error: Aspect ratio must be exactly 2, but found 1.6129 (600x372)
/images/utilities.svg: Error: Aspect ratio must be exactly 2, but found 2.0127 (159x79)
@GarboMuffin GarboMuffin merged commit 5b9aac1 into master Jul 4, 2023
1 check passed
@GarboMuffin GarboMuffin deleted the validate branch July 4, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant