Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update vars and lists #693

Closed
wants to merge 0 commits into from
Closed

update vars and lists #693

wants to merge 0 commits into from

Conversation

qxsck
Copy link
Contributor

@qxsck qxsck commented Jul 4, 2023

No description provided.

@Faris90
Copy link
Contributor

Faris90 commented Jul 4, 2023

Good luck

@@ -12,14 +12,22 @@
clearList: '清空列表 [LIST]',
deleteOfList: '删除列表 [LIST] 的第 [INDEX] 项',
addValueInList: '在列表 [LIST] 末尾添加 [VALUE]',
addListToList: '在列表 [LIST] 末尾添加 [LIST2]',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To reduce ambiguity I changed the English string to be add json [LIST2] to [LIST]; can you update the translation accordingly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为了减少歧义,我将英语字符串更改为 ;你能相应地更新翻译吗?add json [LIST2] to [LIST]

LIST2 is a list rather than JSON, JSON isn't suitable.

Copy link
Member

@GarboMuffin GarboMuffin Jul 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having two separate blocks (addValueInList, addListToList) with the same text but different behavior is untenable, so they will have to be distinguished somehow. do you have a better proposal?

Copy link
Contributor Author

@qxsck qxsck Jul 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

具有两个具有相同文本但不同行为的单独块(addValueInList,addListToList)是站不住脚的,因此必须以某种方式区分它们。你有更好的建议吗?

can replace ‘json’ to ‘list’ in text?

@Skyhigh173
Copy link
Contributor

nice!
How about drop-down menu?

@qxsck
Copy link
Contributor Author

qxsck commented Jul 9, 2023

nice! How about drop-down menu?

what?

@Skyhigh173
Copy link
Contributor

Menu in block, with lists/variables you can choose

@qxsck
Copy link
Contributor Author

qxsck commented Jul 10, 2023

块中的菜单,您可以选择列表/变量

list 和 value 都是字符串,如 "123" 和 "['1','2','3']"

@Skyhigh173
Copy link
Contributor

块中的菜单,您可以选择列表/变量

list 和 value 都是字符串,如 "123" 和 "['1','2','3']"

I mean you can do something like this :
image

This was referenced Aug 22, 2023
Copy link
Contributor

@NexusKitten NexusKitten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR, as well as #658 and #693 haven't been active in almost 6 weeks, are they still being worked on?

@qxsck qxsck closed this Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants