Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

files: Add download URL block #700

Merged
merged 7 commits into from
Jul 8, 2023
Merged

Conversation

CST1229
Copy link
Contributor

@CST1229 CST1229 commented Jul 6, 2023

image
Useful for downloading binary data that downloading as text would mess up, like PNG or zip (hint hint) files.

@LilyMakesThings
Copy link
Contributor

snapshot stage pog

@LilyMakesThings
Copy link
Contributor

While you're there, maybe also put a spacer between the modal selector and download blocks?

@ghost
Copy link

ghost commented Jul 6, 2023

Combine this block with Looks Plus snapshot stage reporter, and you get something awesome!

@CST1229 CST1229 mentioned this pull request Jul 7, 2023
@GarboMuffin
Copy link
Member

you know, I suppose we may as well make this just support all URLs?

@LilyMakesThings
Copy link
Contributor

you know, I suppose we may as well make this just support all URLs?

This would be more than ideal for some developers if they want to have an efficient way to download files from a repo. I can already think of a project I'd make with this.

Any concerns anyone would have about malicious files is made redundant by the fact fetch exists.

@GarboMuffin GarboMuffin changed the title files: Add download data URL block files: Add download URL block Jul 8, 2023
@GarboMuffin GarboMuffin merged commit f63699a into TurboWarp:master Jul 8, 2023
1 check passed
@CST1229 CST1229 deleted the save-data-url branch July 26, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants