TurboHook V.1.1.0 Update #706
Conversation
| embedConnector ({STRING1, STRING2}) { | ||
| STRING1 = Scratch.Cast.toString(STRING1); | ||
| STRING2 = Scratch.Cast.toString(STRING2); | ||
| if (STRING1.includes("author") && STRING2.includes("author")) { |
There was a problem hiding this comment.
making the same mistakes as you did in the original version
you can make this work without duplicating all sorts of code and in a way that is much more reliable
There was a problem hiding this comment.
believe what you want is something like "js deep merge objects", but also be careful of "prototype pollution" bugs
|
the documentation should contain some actual examples at this point going to be honest, the entire system of reporters and connectors you have seems to just add a whole lot of complexity that a couple "set text to [ ]" blocks would've avoided... |
|
These days, I've been thinking about the future of TurboHook. Since TurboHook was meant for webhooks, it should just be webhooks. Nothing specific. I've been thinking of overhauling the entire system for TurboHook. After I've had people legitimately use it for webhooks other than those of Discord, I've been thinking of changing the entire setup of TurboHook to have 1 - 3 simple blocks meant for webhooks. I've been thinking of it ever since I added JSON support. So I might take down this PR and put up a V.2.0.0 PR for TurboHook with an entire overhaul of it. Just a quick question, all I have to do to remove previous blocks is just add "hideFromPalatte = true"? |
|
Sorry, didn't mean to request a review here. |
Correct |
Lol you didn't have to tell me, I found out some time later. |
Hello again! I'm putting up the PR again because I did some fatal merges to the master branch of my fork, causing me to have to delete my entire fork. So using my backups, I remade the PR. So let me reiterate the last PR:
The moment everyone's been waiting for... TurboHook V.1.1.0!!!
This update includes full embed support, JSON support, bugfixes, typo fixes, some semi colons, extra space removals, and so much more.
Here is the current roster:
