Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added my "Geolocation" extensions #725

Closed
wants to merge 2 commits into from
Closed

Added my "Geolocation" extensions #725

wants to merge 2 commits into from

Conversation

samuellouf
Copy link
Contributor

I created a Geolocation extension.
Here are the blocks :
geolocation extension blocks

Tell me what you think.

@CubesterYT
Copy link
Collaborator

I will like to say three things. One, is this extension going to be used for checking user location? Like apps like maps and other programs? Two, what is the timeout blocks for? Three, in index.ejs, the banner must be a .svg image banner, not your .js file, so create a image banner that is 600 wide and 300 tall and add the .svg to a folder named to your name in the image folder.

@yuri-kiss
Copy link
Contributor

dangerous

@yuri-kiss
Copy link
Contributor

unless you makin a maps app lol

@LilyMakesThings
Copy link
Contributor

Add an IP Address block while you're at it

@NexusKitten

This comment was marked as spam.

@samuellouf
Copy link
Contributor Author

One, is this extension going to be used for checking user location? Like apps like maps and other programs?

Yes.

Two, what is the timeout blocks for?

The extension will try to get the user's current location. If a certain amount of time is passed, the extension will return an error.

And also @NexusKitten is right, it's a dangerous extension.

@samuellouf samuellouf closed this Jul 11, 2023
@GarboMuffin
Copy link
Member

if we just add something like Scratch.canGeolocate() that asks the user, this is fine

@GarboMuffin GarboMuffin reopened this Jul 11, 2023
@CubesterYT
Copy link
Collaborator

YES REVIVED!!!

@ghost
Copy link

ghost commented Jul 11, 2023

Remove latitude and longitude, and replace it with current city and current country. That would be safer, I think.

@GarboMuffin
Copy link
Member

as long as it has user consent, precise position to the millimeter is perfectly fine

@samuellouf samuellouf closed this by deleting the head repository Jul 21, 2023
@CubesterYT
Copy link
Collaborator

Dang bruh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants