Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add More Motion #732

Merged
merged 22 commits into from
Jul 23, 2023
Merged

Add More Motion #732

merged 22 commits into from
Jul 23, 2023

Conversation

NexusKitten
Copy link
Contributor

More Motion is an extension to add several utility blocks pertaining to the "Motion" category, such as blocks for distance, stepping, and checking position. Although it's blocks are somewhat limited as of currently, I wanted to set the groundwork for a motion extension since we don't currently have one yet.

image (30)

@idoinfactexist
Copy link

call it motion plus, its just too easy

@ghost
Copy link

ghost commented Jul 13, 2023

YESSSS MOTION+ I WAS WAITING FOR THIS

@Drago-Cuven
Copy link

(distance between (x1) (y1) and (x2) (y2))

@NexusKitten

This comment was marked as spam.

@NexusKitten NexusKitten changed the title Add More Motion Add Motion Plus Jul 14, 2023
@NexusKitten NexusKitten changed the title Add Motion Plus Add Moiton Plus Jul 14, 2023
@NexusKitten NexusKitten changed the title Add Moiton Plus Add Moist Jul 14, 2023
@NexusKitten NexusKitten changed the title Add Moist Add More Emotion 😔 Jul 14, 2023
@NexusKitten NexusKitten changed the title Add More Emotion 😔 Add Motion Plus Deluxe + Bowser's Fury 2 [NEW FUNKY MODE] Jul 15, 2023
@NexusKitten NexusKitten changed the title Add Motion Plus Deluxe + Bowser's Fury 2 [NEW FUNKY MODE] Add Wii Accessory Released in 2009 Jul 15, 2023
@CubesterYT
Copy link
Collaborator

@NexusKitten are you ok lol?

@GarboMuffin
Copy link
Member

GarboMuffin commented Jul 15, 2023

please keep the pull request names reasonable if you want them to be looked at.

@GarboMuffin GarboMuffin changed the title Add Wii Accessory Released in 2009 Add More Motion Jul 15, 2023
@NexusKitten

This comment was marked as spam.

@BlueDome77
Copy link
Contributor

It should just be called Motion Plus to match the other category expansion extensions

@NexusKitten

This comment was marked as spam.

@GarboMuffin
Copy link
Member

I made some changes

  • distinction between costume size and actual sprite size after rotation, etc.
  • touching point works with rotation etc. and checks if the costume actually exists at that point
  • rectangle touching block now works with rotation etc. and checks if any part of the costume actually intersects the rectangle (it also fixes the argument order if someone gets it backwards)

the last 2 are significant breaking changes, so let me know if you need the old behavior back

@LilyMakesThings
Copy link
Contributor

LilyMakesThings commented Jul 23, 2023

"touching" as a concept is a sensing thing. Wouldn't it make more sense within sensing+?

"Motion" describes movement, and the reporters in the motion category typically get an axis of movement, not a condition. Otherwise, distance would've been in motion.

@NexusKitten

This comment was marked as spam.

@GarboMuffin GarboMuffin merged commit d4c4678 into TurboWarp:master Jul 23, 2023
@NexusKitten NexusKitten deleted the moremotion branch August 24, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants