Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skins: Add Skins Extension #764

Merged
merged 25 commits into from
Aug 7, 2023
Merged

Conversation

LilyMakesThings
Copy link
Contributor

@LilyMakesThings LilyMakesThings commented Jul 19, 2023

Skins aims to be an expanded version of the SVG block in Looks Plus, but with support for bitmap images as well as separate clone skins.

image

I urge you to give it a try, and suggest ideas for blocks!

(Please note, I will not be adding the replace color block, or similar blocks to this extension. That will be left for a separate extension I am working on)

- Removed unnecessary check in _getTargets function
- Added Scratch.canFetch check for _createURLSkin
@LilyMakesThings
Copy link
Contributor Author

LilyMakesThings commented Jul 19, 2023

I am not fixing those errors

Edit: nvm I fixed one

@LilyMakesThings LilyMakesThings marked this pull request as ready for review July 19, 2023 03:40
- Removed 4am code
- Fixed an error that I know what it means now that I'm not tired
- Remove commented code
@LilyMakesThings
Copy link
Contributor Author

What is the cause of that error? I've tried fixing it before but to no avail

@CST1229
Copy link
Collaborator

CST1229 commented Jul 23, 2023

What is the cause of that error?

It's because you're using Image(), and setting the src of an Image sends a network request without the user's permission. I think the linter isn't (and probably won't be) smart enough to detect that you've used Scratch.fetch() with that same URL before and there is no Scratch.Image(), so you'll have to do what the message says:

then add // eslint-disable-next-line no-restricted-syntax

@LilyMakesThings
Copy link
Contributor Author

What is the cause of that error?

It's because you're using Image(), and setting the src of an Image sends a network request without the user's permission. I think the linter isn't (and probably won't be) smart enough to detect that you've used Scratch.fetch() with that same URL before and there is no Scratch.Image(), so you'll have to do what the message says:

then add // eslint-disable-next-line no-restricted-syntax

Thank you so much

@LilyMakesThings LilyMakesThings marked this pull request as draft July 28, 2023 08:41
@LilyMakesThings
Copy link
Contributor Author

Some problems have been noted regarding the rotation center of skins, which will require a new block and a patch

- Preserve rotation center on costume skins
Note for maintainers:
- I placed the extension next to Pen Plus because we're working on a new extension that is designed to be used by both Pen Plus and Skins equally. We're doing this to avoid several duplicate blocks and missing features. We want to keep them in a group, so take this into consideration.
@LilyMakesThings LilyMakesThings marked this pull request as ready for review July 29, 2023 02:35
@LilyMakesThings
Copy link
Contributor Author

LilyMakesThings commented Jul 29, 2023

We do not need to add any new blocks for now. This extension is complete.

@GarboMuffin GarboMuffin merged commit 09d44cc into TurboWarp:master Aug 7, 2023
1 check passed
@LilyMakesThings LilyMakesThings deleted the Skins branch August 11, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants