Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Trampoline Extension (S-Grab Replacement) #803

Closed
wants to merge 4 commits into from
Closed

Add Trampoline Extension (S-Grab Replacement) #803

wants to merge 4 commits into from

Conversation

NexusKitten
Copy link
Contributor

@NexusKitten NexusKitten commented Jul 29, 2023

Partially resolves #761
Adds Trampoline, an extension for retrieving information from Scratch users and projects, using a combination of the TurboWarp Trampoline API and Scratch API, and removes/fixes S-Grab (#371) due to copyright, as well as several major bugs.
image

@NexusKitten

This comment was marked as resolved.

@cally-jt
Copy link

why though?

@cally-jt
Copy link

why though?

cant you just update s-grab?

@NexusKitten

This comment was marked as spam.

@cally-jt
Copy link

cally-jt commented Aug 5, 2023

why though?

cant you just update s-grab?

The two extensions use different APIs; S-Grab runs on Scratch DB, which is the same thing ScratchStats uses. Trampoline uses the Turbowarp Trampoline API, and the base Scratch API. Although the two extensions have some overlapping blocks, they're internally very different. However, S-Grab still has some blocks exclusive to Scratch DB, so I'm keeping it as a hidden extension to be thorough.

I see

@LilyMakesThings
Copy link
Contributor

It's also standard for us to move our extension rewrites to a new file, especially when having them in the same file would mean hiding all of the old blocks.

@NexusKitten

This comment was marked as spam.

@NexusKitten

This comment was marked as spam.

@NexusKitten

This comment was marked as spam.

@NexusKitten NexusKitten reopened this Sep 14, 2023
@NexusKitten NexusKitten marked this pull request as ready for review September 15, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants