Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New extension: Mobile keyboard #825

Merged
merged 41 commits into from
May 9, 2024

Conversation

veggiecan0419
Copy link
Contributor

@veggiecan0419 veggiecan0419 commented Aug 1, 2023

New extension: Mobile keyboard

Blocks that show the keyboard on mobile devices and get the users input without showing any sort of input modal.

THE THUMBNAIL:

mobilekeyboard thumbnail

THE BLOCKS:

mobile keyboard blocks
newblocks

THE POSSIBLE KEYBOARD TYPES:

keyboard types menu items

NOTES:

This extension has only been tested out on a samsung galaxy A12 and a MediaTek TV, though it should show the keyboard on any device with an on-screen keyboard, and should get the users input without showing any sort of input modal on ALL devices (ie. if you run the 'show alphabetical keyboard' block on a computer, the 'typed text' monitor should be recording whatever you type untill you click the enter key).

@SharkPool-SP
Copy link
Collaborator

this is cool.

@Skyhigh173
Copy link
Contributor

Does it support iOS

@NexusKitten

This comment was marked as spam.

@veggiecan0419 veggiecan0419 marked this pull request as ready for review August 5, 2023 16:06
@veggiecan0419
Copy link
Contributor Author

Does it support iOS

@Skyhigh173
We've updated the cover message.
See the notes section.

@veggiecan0419
Copy link
Contributor Author

This extension looks cool, I haven't gotten to test it yet however one thing I notice the block pallete is the newline keyboard blocks, wouldn't those make sense in a drop-down with the other types of keyboards?

@NexusKitten
Done ✔️.
We had initially had them as separate blocks because they use two different javascript functions, but now we combined them into one block as it does make more sense that way.

@veggiecan0419

This comment was marked as outdated.

@CST1229
Copy link
Collaborator

CST1229 commented Aug 10, 2023

Could you please also add it to the in-built extension gallery (here basically⤵️) as we couldn't figure out how to do it.

That's in scratch-gui, and I doubt he'll add it (as I think that gallery is for the highest-quality and most useful extensions).

@veggiecan0419
Copy link
Contributor Author

@GarboMuffin
We will be making a few changes. Please don't merge this yet.

@GarboMuffin GarboMuffin marked this pull request as draft August 30, 2023 05:12
@GarboMuffin
Copy link
Member

There is a button to mark "Ready for review" at the bottom of the page

@veggiecan0419
Copy link
Contributor Author

@GarboMuffin, can we disable ESlint on SVG images? (Because it keeps complaining about the ratio not being EXACTLY 300×600px)

@GarboMuffin
Copy link
Member

The aspect ratio must be exactly 2. I deal with that error if you do not.

@veggiecan0419

This comment was marked as outdated.

@veggiecan0419 veggiecan0419 reopened this Oct 5, 2023
@veggiecan0419
Copy link
Contributor Author

I wonder why force-pushing closed the PR?

@veggiecan0419 veggiecan0419 marked this pull request as ready for review October 5, 2023 02:16
@veggiecan0419
Copy link
Contributor Author

@GarboMuffin , I think it should be ready to merge

@CubesterYT
Copy link
Collaborator

I wonder why force-pushing closed the PR?

@veggiecan0419, force pushing deletes the other branch to add the contents of the branch to the one you are force pushing it to. Deleting the branch causes the PR the PR was made with to be deleted as well.

@GarboMuffin GarboMuffin self-requested a review February 28, 2024 06:25
@GarboMuffin
Copy link
Member

hello sorry for delay, i've made some changes and tested them on an Android, do they seem good to you?

@GarboMuffin
Copy link
Member

if it looks good to you then comment here; if it takes >24hrs to get merged after that then email [email protected] because your comment got lost in my notifications

@veggiecan0419
Copy link
Contributor Author

@GarboMuffin

Yes, looks good 👍. A lot better than before.
Thanks a lot :)

@GarboMuffin GarboMuffin merged commit 6e8d4fc into TurboWarp:master May 9, 2024
3 checks passed
@veggiecan0419 veggiecan0419 deleted the mobilekeyboard branch May 9, 2024 18:37
@veggiecan0419
Copy link
Contributor Author

Yay! 🥳

@Skyhigh173
Copy link
Contributor

it seems this extension doesn't work on iOS

@GarboMuffin
Copy link
Member

if you have an iphone then you can help us fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants