Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resolve block to math.js #873

Closed
wants to merge 2 commits into from
Closed

Add resolve block to math.js #873

wants to merge 2 commits into from

Conversation

TheShovel
Copy link
Contributor

Screenshot_20230810_185303

@yuri-kiss
Copy link
Contributor

oo

@LilyMakesThings
Copy link
Contributor

finally, math in the math extension

@yuri-kiss
Copy link
Contributor

lol

NexusKitten
NexusKitten approved these changes Aug 26, 2023
View reviewed changes
Copy link
Contributor

@NexusKitten NexusKitten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version of Math.js is slightly out of date (it doesn't have the metadata header like it now does), but other than that, everything looks good!

@TheShovel
Copy link
Contributor Author

This version of Math.js is slightly out of date (it doesn't have the metadata header like it now does), but other than that, everything looks good!

Garbo has to resolve that. This PR was made before those headers existed.

@NexusKitten NexusKitten mentioned this pull request Aug 30, 2023
Merged
@GarboMuffin
Copy link
Member

Closing per request of author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NexusKitten NexusKitten NexusKitten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TheShovel @yuri-kiss @LilyMakesThings @GarboMuffin @NexusKitten