Fix grammar and block in 'Time' extension #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Block, Extract () from () was broken and was returning NaN
|
don't have them capitalised, it's inconsistent with other extensions |
Decapitalised first letter
|
Decapitalised the first letter of block names |
|
Wait, I don't think you can change the argument type according to compatibility docs. I think you might have to make a new block with the fix. How was this not caught during it's development??? |
|
An argument type change from 'NUMBER' to 'STRING' is typically safe both ways however argument id's and block opcodes has to be the same |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Block, Extract () from () was broken and was returning NaN.
Grammar also fixed in some blocks