Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add getPenDrawableId() -- RenderWebGL.js #8

Closed
wants to merge 1 commit into from

Conversation

SharkPool-SP
Copy link

Cross compatibility with PenguinMod

Helper function to, as the name says, get the Drawable ID of the Pen layer

@FurryR
Copy link

FurryR commented Mar 19, 2024

This function is unnecessary as it can be polyfilled by users and was not used by any official Turbowarp code.

Also, JSDoc is not provided. Please describe what does it return, or it might not able to merge.

You are required to follow git commit message standard instead of using Update RenderWebGL.js so we can clearly know what you have changed in each commit.

By the way, please do not use web editor to contribute your code if it is possible. Web editor is lack of many critical features that helps you review the code before you commit. GitHub Codespaces is a nice solution if you are not able to configure an environment yourself.

@SharkPool-SP
Copy link
Author

This function is unnecessary as it can be polyfilled by users and was not used by any official Turbowarp code.

Also, JSDoc is not provided. Please describe what does it return, or it might not able to merge.

You are required to follow git commit message standard instead of using Update RenderWebGL.js so we can clearly know what you have changed in each commit.

By the way, please do not use web editor to contribute your code if it is possible. Web editor is lack of many critical features that helps you review the code before you commit. GitHub Codespaces is a nice solution if you are not able to configure an environment yourself.

Idk what half of that means 😭

@GarboMuffin
Copy link
Member

Fyi we don't use semantic commit messages here

@SharkPool-SP
Copy link
Author

Fyi we don't use semantic commit messages here

sadge, you can close this if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants