Super scary extension development improvments. #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GarboMuffin @CubesterYT if you could take a peek when you have time. |
GarboMuffin
reviewed
May 21, 2025
| @@ -130,6 +130,42 @@ class ExtensionManager { | |||
| dispatch.setService('extensions', createExtensionService(this)).catch(e => { | |||
| log.error(`ExtensionManager was unable to register extension service: ${JSON.stringify(e)}`); | |||
| }); | |||
|
|
|||
| // Allow for sandboxed extensions, and worker extensions to access some of our APIs. | |||
There was a problem hiding this comment.
i'll just say right away that extending worker extensions with more powers is probably just not going to happen; if anything these are getting removed entirely
There was a problem hiding this comment.
I know they are going to get removed but they exist right now, so I don't see why it cant be added now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
This could be used to resolve issues with the JSON extension where it returns values that contain null / undefined.
Proposed Changes
Export's a bunch of stuff (lazily) and add's more Casting utility's.
This also add's support for sandboxed extensions to call
extensionManager.refreshBlocksandextensionManger.loadExtensionIdSync; with parity changes added to the unsandboxed runtime to include these functions as-well.Reason for Changes
Allows for extensions to access internal classes and utility's a lot easier.
Extra casting stuff was added for adding a centralized area for thoe's type of casts. (mainly meant for the JSON & BigInt extension)
-# Super scary require function export is uhh because it is useful to have it in userscripts and alike, and there is no good reason not to add an even scarier way to get it I guess.