Apply suggestions from code review

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
TuringLang · Nov 7, 2023 · fc6a051 · fc6a051
1 parent 8ce53f7
commit fc6a051
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 17 deletions.
diff --git a/src/varinfo.jl b/src/varinfo.jl
@@ -908,7 +908,6 @@ istrans(vi::VarInfo, vn::VarName) = istrans(getmetadata(vi, vn), vn)
 istrans(md::Metadata, vn::VarName) = is_flagged(md, vn, "trans")
 istrans(vnv::VarNameVector, vn::VarName) = !(gettransform(vnv, vn) isa FromVec)
 
-
 getlogp(vi::VarInfo) = vi.logp[]
 
 function setlogp!!(vi::VarInfo, logp)

diff --git a/src/varnamevector.jl b/src/varnamevector.jl
@@ -4,7 +4,7 @@ struct VarNameVector{
     TIdcs<:OrderedDict{<:VarName,Int},
     TVN<:AbstractVector{<:VarName},
     TVal<:AbstractVector,
-    TTrans<:AbstractVector
+    TTrans<:AbstractVector,
 }
     "mapping from the `VarName` to its integer index in `vns`, `ranges` and `dists`"
     idcs::TIdcs # Dict{<:VarName,Int}
@@ -44,9 +44,7 @@ Bijectors.inverse(f::FromVec{Tuple{}}) = tovec
 VarNameVector(x::AbstractDict) = VarNameVector(keys(x), values(x))
 VarNameVector(vns, vals) = VarNameVector(collect(vns), collect(vals))
 function VarNameVector(
-    vns::AbstractVector,
-    vals::AbstractVector,
-    transforms = map(FromVec, vals)
+    vns::AbstractVector, vals::AbstractVector, transforms=map(FromVec, vals)
 )
     # TODO: Check uniqueness of `vns`?
 
@@ -107,7 +105,7 @@ Base.getindex(vnv::VarNameVector, spl::AbstractSampler) = vnv[:]
 Base.setindex!(vnv::VarNameVector, val, i::Int) = vnv.vals[i] = val
 function Base.setindex!(vnv::VarNameVector, val, vn::VarName)
     f = inverse(gettransform(vnv, vn))
-    vnv.vals[getrange(vnv, vn)] = f(val)
+    return vnv.vals[getrange(vnv, vn)] = f(val)
 end
 
 function Base.empty!(vnv::VarNameVector)
@@ -146,7 +144,7 @@ function group_by_symbol(vnv::VarNameVector)
         VarNameVector(
             map(identity, vns),
             map(Base.Fix1(getindex, vnv), vns),
-            map(Base.Fix1(gettransform, vnv), vns)
+            map(Base.Fix1(gettransform, vnv), vns),
         )
     end
 

diff --git a/test/varnamevector.jl b/test/varnamevector.jl
@@ -1,14 +1,6 @@
 @testset "VarNameVector" begin
-    vns = [
-        @varname(x[1]),
-        @varname(x[2]),
-        @varname(x[3]),
-    ]
-    vals = [
-        1,
-        2:3,
-        reshape(4:9, 2, 3),
-    ]
+    vns = [@varname(x[1]), @varname(x[2]), @varname(x[3])]
+    vals = [1, 2:3, reshape(4:9, 2, 3)]
     vnv = VarNameVector(vns, vals)
 
     # `getindex`