-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Perform invlinking in assume rather than implicitly in getindex #360
Closed
Closed
Changes from 24 commits
Commits
Show all changes
107 commits
Select commit
Hold shift + click to select a range
14594d6
performing linking in assume rather than implicitly in getindex
torfjelde 0bc279f
added istrans to SimpleVarInfo
torfjelde 81ee12e
Apply suggestions from code review
torfjelde d39f87d
added a comment
torfjelde 23f34cc
bump patch version
torfjelde d3ec108
introduced settrans!!
torfjelde 81782c9
added istrans(vi) and renamed all occurences of trans! to trans!!
torfjelde 12bfb42
exclusively use settrans!! to set the istrans for SimpleVarInfo
torfjelde c2c2417
removed usage of deprecated method in turing tests
torfjelde 2e2cb5c
added docstring to settrans!!
torfjelde f6c3fc4
include istrans flag in type of SimpleVarInfo instead
torfjelde d643a78
deprecated settrans! in favour of settrans!!
torfjelde 3cab7d9
added some tests specifically for istrans
torfjelde 8b870dc
formatting
torfjelde 0b304db
fixed bugs for ThreadSafeVarInfo
torfjelde b146b11
additional constructor for SimpleVarInfo
torfjelde d170d92
Update src/DynamicPPL.jl
torfjelde f46183b
added ConstructionBase.jl as dep
torfjelde 7a78eec
added constraint types and doctests
torfjelde 70b3b70
added DocStringExtensions as a dep
torfjelde a03e8cf
formatting
torfjelde 793c931
remove redundant maybe_link
torfjelde a9b12fd
fixed typo
torfjelde b1d7f9a
Merge branch 'master' into tor/link-improvements
yebai be98961
moved a docstring
torfjelde 3e1588b
fixed bug in tets
torfjelde 7697fce
Merge branch 'tor/link-improvements' of github.com:TuringLang/Dynamic…
torfjelde 3139c62
version bump
torfjelde 3610658
added missing istrans impl
torfjelde 27171ad
fixed bug with istrans
torfjelde cd2d9d6
fixed issue with getindex_raw for VarInfo
torfjelde d948cb9
Update src/varinfo.jl
torfjelde 6a3e18f
Merge branch 'master' into tor/link-improvements
torfjelde d674478
Merge branch 'master' into tor/link-improvements
torfjelde 26d2dbb
getindex of varinfo implementations now optionally takes a Distributi…
torfjelde 3fcba56
use get_index_raw with dist argument
torfjelde 83a9448
added missing assume implementations for SimpleVarInfo
torfjelde 356fa9c
fixed settrans!! for VarInfo
torfjelde 13f037f
formatting
torfjelde c7544e0
fixed bug where constrained/unconstrained wasn't preserved in setinde…
torfjelde d1dccf1
hack to avoid type-instabilities for dot_assume with MultivariateDist…
torfjelde ff7ff4a
style
torfjelde 2f1a2ff
added keys implementations for the models in TestUtils to make testin…
torfjelde d6311b7
added additional test model which uses dot-assume on MultivariateDist…
torfjelde ed2fa69
updated tests for SimpleVarInfo
torfjelde a82be56
added a no-op reconstruct for UnivariateDistribution
torfjelde 7aacee5
fixed tests for loglikelihoods
torfjelde 96f128f
fixed dot_tilde_assume for LikelihoodContext
torfjelde 2e88d08
removed some now redundant explicit calls to maybe_invlink
torfjelde 0f9765b
added impls of size and length for the wrapper distributions so they …
torfjelde 116c95c
bumped version
torfjelde d797e99
removed redunant explict call to maybe_invlink
torfjelde 44b2f66
added test model with array on RHS of a .~ statement
torfjelde 81cd881
improved some of the default implementations of dot_assume
torfjelde 2e14abd
removed unnecessary code in tests
torfjelde 12adc83
improved linking usage in assumes for SimpleVarInfo
torfjelde af3e6ba
Merge branch 'master' into tor/link-improvements
yebai f7501df
added model for testing dynamic constraints
torfjelde abcabf4
added logjoint_true_with_logabsdet_jacobian to TestUtils
torfjelde fdee509
added test for dynamic constraints for SimpleVarInfo
torfjelde e974c83
fixed keys implementation of SimpleVarInfo
torfjelde 6c6d5f5
reverted unintended change
torfjelde 801bd4c
renamed Base.keys(model) to varnames(model) in TestUtils
torfjelde 46f6f4c
added default implementation and docstring for TestUtils.varnames
torfjelde bcb767b
replace handwritten by DocStringExtensions
torfjelde c5be1c2
Apply suggestions from @devmotion
torfjelde f266929
Update src/context_implementations.jl
torfjelde c2dbbaf
removed some asserts and use broadcast instead of map
torfjelde 1abb46c
replace map with broadcasting to ensure consistent behavior
torfjelde 1086c6c
Update src/simple_varinfo.jl
torfjelde f2fb4a5
added a method nodist to allow broadcasting NoDist constructor
torfjelde 490d24e
updated some tests
torfjelde 6350ccd
renamed AbstractConstraint to AbstractTransformation and its subtypes
torfjelde 951e4c3
updated tests
torfjelde dcd92c9
fixed nodist usage
torfjelde 2922ffa
fixed implementation of nodist
torfjelde 5266a4b
fixed typo
torfjelde 3c38710
formatting
torfjelde ba92f3f
bump patch version
torfjelde 70c864c
fixed ThreadsafeVarInfo
torfjelde 66f41a9
Apply suggestions from code review
torfjelde eb2d6b5
allow type-stable settrans!! for SimpleVarInfo
torfjelde e8cdb91
use maybe_invlink in getindex for VarInfo
torfjelde 359d384
added comment to warn about buggy behavior
torfjelde ab0a99b
Update src/context_implementations.jl
torfjelde dd10913
just fix potential bug in getindex for VarInfo
torfjelde 18d28cc
revert previous change because it likely introduces bugs
torfjelde 32b7aab
elaborate in comment regarding potential bug
torfjelde fb86231
Merge branch 'tor/link-improvements' of github.com:TuringLang/Dynamic…
torfjelde f782fe2
added error message to dot_assume
torfjelde 7d3493d
added error message to dot_assume again
torfjelde f0f981b
added _protect_dists method to help with broadcasting of NoDist
torfjelde 1e0b946
simplified show for SimpleVarInfo
torfjelde faa0e42
styling
torfjelde 9e7f493
fixed bug in show for SimpleVarInfo
torfjelde 0a9383b
Revert "added _protect_dists method to help with broadcasting of NoDist"
torfjelde d8b0a75
fixed getindex with vector of varnames for AbstractVarInfo
torfjelde 400f90f
Improvements to TestUtils (follow-up from #360) (#415)
torfjelde 9241acd
fixed tests for distribution_wrappers
torfjelde 947e5c6
upper bound Distributions because tests are sooooo slow due to deprec…
torfjelde 6f9be0d
Update bors.toml
yebai 5c5b9ce
Revert "Update bors.toml"
torfjelde e0797cc
Revert "upper bound Distributions because tests are sooooo slow due t…
torfjelde 4b0e0e1
switch of deprecation warnings from integration tests for now
torfjelde 5a73c87
bump supported Julia version to 1.6
torfjelde bb43021
added ability to filter varnames to check in TestUtils.test_sampler
torfjelde d5a48f8
bump minor version
torfjelde File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it'll be nice if we can overload the transform used inside
logpdf_with_trans
in the future.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can actually replace the above with
right now. But I think if we do this we should remove
logpdf_with_trans
everywhere, so I wanted to defer that to another PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@phipsgabler this is what I mentioned today. We can now replace
logpdf_with_trans
with ChangeOfVariables/LogDensityInterface API.#342