Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for type instability when using LKJChol #548

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

torfjelde
Copy link
Member

See TuringLang/Turing.jl#2102 for issue.

When adding tests for this I noticed that some of the DEMO_MODELS are not type-stable (even though they should be). This is probably relate to #530, but let's defer these to a different PR.

@yebai
Copy link
Member

yebai commented Oct 23, 2023

probably relate to #530, but let's defer these to a different PR.

@sunxd3 is working on a fix for #530

@yebai yebai requested a review from sunxd3 October 23, 2023 16:52
@torfjelde torfjelde mentioned this pull request Oct 23, 2023
@github-actions
Copy link
Contributor

Pull Request Test Coverage Report for Build 6616405812

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.767%

Totals Coverage Status
Change from base Build 6577734451: 0.0%
Covered Lines: 2632
Relevant Lines: 3180

💛 - Coveralls

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (efd9da3) 82.76% compared to head (53e07cd) 82.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #548   +/-   ##
=======================================
  Coverage   82.76%   82.76%           
=======================================
  Files          25       25           
  Lines        3180     3180           
=======================================
  Hits         2632     2632           
  Misses        548      548           
Files Coverage Δ
src/utils.jl 81.49% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@torfjelde torfjelde enabled auto-merge October 23, 2023 17:18
@torfjelde torfjelde closed this Oct 23, 2023
auto-merge was automatically disabled October 23, 2023 17:18

Pull request was closed

@torfjelde torfjelde reopened this Oct 23, 2023
@torfjelde torfjelde enabled auto-merge October 23, 2023 17:19
@torfjelde
Copy link
Member Author

Sorry; accidentally closed this.

@torfjelde torfjelde added this pull request to the merge queue Oct 23, 2023
Merged via the queue into master with commit 12e7c27 Oct 23, 2023
23 of 25 checks passed
@torfjelde torfjelde deleted the torfjelde/type-stability-for-lkj branch October 23, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants