-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ZygoteRules and ChainRulesCore weak dependencies #564
Conversation
Pull Request Test Coverage Report for Build 6947129998
💛 - Coveralls |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #564 +/- ##
==========================================
+ Coverage 80.26% 81.00% +0.74%
==========================================
Files 26 26
Lines 3167 3170 +3
==========================================
+ Hits 2542 2568 +26
+ Misses 625 602 -23 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! One thing though: do we know why compat is complaining? Or is codecov only run on Julia 1.9?
Coverage analysis was only performed on Julia 1.9. |
Good to go, @torfjelde? |
Aye:) |
IMO these overloads in the
compat
subfolder are natural candidates for a weak dependency.