Add acclogp_assume!! and acclogp_observe!!
#565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 6977964954
💛 - Coveralls |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #565 +/- ##
==========================================
+ Coverage 81.00% 81.03% +0.02%
==========================================
Files 26 26
Lines 3170 3174 +4
==========================================
+ Hits 2568 2572 +4
Misses 602 602 ☔ View full report in Codecov by Sentry. |
|
Related to #390? |
torfjelde
commented
Nov 21, 2023
yebai
reviewed
Nov 21, 2023
yebai
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
Thanks @torfjelde -- while I am happy with these changes, I find the increasingly deeper tilde pipeline hard to read. We should improve the docs, or try to simplify that in the future.
Co-authored-by: Hong Ge <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new methods:
acclogp_assume!!acclogp_observe!!The idea is to provide slightly more control over the
acclogp!!process, beyond (#563).The main motivation for this, is to fix the bug where particle samplers in Turing.jl currently do not respect the contextual tilde-pipeline since we accumulate the
logpin the "leaf" of the tilde-pipeline, e.g.observeandassume:This means that any context which alters the value of
logp, e.g.MiniBatchContext, will have no effect.After this PR, particle samplers can overload
acclogp_observe!!to runLibtask.produce(logpdf(dist, value)), which occurs at the very end of the tilde-pipeline, hence allowing these samplers to also respect the context behaviors.