-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test error with Turing >= 0.30 #570
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Pull Request Test Coverage Report for Build 7604303730
💛 - Coveralls |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #570 +/- ##
==========================================
+ Coverage 79.64% 84.30% +4.65%
==========================================
Files 26 26
Lines 2938 3172 +234
==========================================
+ Hits 2340 2674 +334
+ Misses 598 498 -100 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with the one outstanding comment/question: should we bump the version used in CI to work with test/turing
?
Feel free to hit merge whenever! |
The PR updates the Turing tests for the changes in version 0.30.
I expect that the LKJ tests still fail due to an unfortunate behaviour of LinearAlgebra in Julia 1.10:
On previous Julia versions this example worked:
On the Julia master branch the problem was fixed (maybe in JuliaLang/julia#52464?) but I wonder if we could make the
Vector{Real}
that shows up in DynamicPPL and Bijectors in the first place to avoid this problem also on Julia 1.10. Alternatively, we could useBijectors.pd_upper(X) = collect(UpperTriangular(X)') * collect(UpperTriangular(X))
etc. on Julia 1.10.