Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better init_theta size mismatch error #576

Merged
merged 6 commits into from
Feb 29, 2024

Conversation

alyst
Copy link
Contributor

@alyst alyst commented Feb 3, 2024

Just a tiny tweak. Providing how exactly the sizes do not match helps debugging.

@yebai yebai requested a review from sunxd3 February 14, 2024 14:57
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.47%. Comparing base (a020171) to head (63c0354).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #576   +/-   ##
=======================================
  Coverage   84.47%   84.47%           
=======================================
  Files          28       28           
  Lines        3207     3207           
=======================================
  Hits         2709     2709           
  Misses        498      498           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yebai yebai enabled auto-merge February 29, 2024 19:21
@coveralls
Copy link

coveralls commented Feb 29, 2024

Pull Request Test Coverage Report for Build 8102638906

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 25 unchanged lines in 4 files lost coverage.
  • Overall coverage remained the same at 84.789%

Files with Coverage Reduction New Missed Lines %
src/model.jl 1 89.22%
src/simple_varinfo.jl 6 80.66%
src/varinfo.jl 6 92.6%
src/threadsafe.jl 12 53.1%
Totals Coverage Status
Change from base Build 8101420428: 0.0%
Covered Lines: 2709
Relevant Lines: 3195

💛 - Coveralls

src/sampler.jl Outdated Show resolved Hide resolved
@yebai yebai disabled auto-merge February 29, 2024 21:43
@yebai yebai enabled auto-merge February 29, 2024 21:43
@yebai
Copy link
Member

yebai commented Feb 29, 2024

Thanks @alyst!

@yebai yebai added this pull request to the merge queue Feb 29, 2024
Merged via the queue into TuringLang:master with commit 2bc717c Feb 29, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants