Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing kwarg not handled correctly #617

Merged
merged 5 commits into from
Jun 12, 2024
Merged

missing kwarg not handled correctly #617

merged 5 commits into from
Jun 12, 2024

Conversation

torfjelde
Copy link
Member

TuringLang/Turing.jl#2259

We perform the inargnames check for both args and kwargs, and so then we should also perform the ismissing check for both args and kwargs (only do it for args atm).

@torfjelde
Copy link
Member Author

@yebai might want to have a look

@github-actions GitHub Actions
Copy link
Contributor

Pull Request Test Coverage Report for Build 9481723129

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 25 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-1.5%) to 78.897%
Files with Coverage Reduction New Missed Lines %
src/model.jl 1 88.35%
src/varinfo.jl 6 92.13%
src/simple_varinfo.jl 6 82.61%
src/threadsafe.jl 12 53.51%
Totals Coverage Status
Change from base Build 9387717755: -1.5%
Covered Lines: 2718
Relevant Lines: 3445
💛 - Coveralls

@github-actions GitHub Actions
Copy link
Contributor

Pull Request Test Coverage Report for Build 9481726759

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.3%) to 79.071%
Totals Coverage Status
Change from base Build 9387717755: -1.3%
Covered Lines: 2724
Relevant Lines: 3445
💛 - Coveralls

@github-actions GitHub Actions
Copy link
Contributor

Pull Request Test Coverage Report for Build 9481723129

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 25 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-1.5%) to 78.897%
Files with Coverage Reduction New Missed Lines %
src/model.jl 1 88.35%
src/varinfo.jl 6 92.13%
src/simple_varinfo.jl 6 82.61%
src/threadsafe.jl 12 53.51%
Totals Coverage Status
Change from base Build 9387717755: -1.5%
Covered Lines: 2718
Relevant Lines: 3445
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 12, 2024 •
edited by github-actions bot
Loading

Pull Request Test Coverage Report for Build 9481726759

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.3%) to 79.071%
Totals Coverage Status
Change from base Build 9387717755: -1.3%
Covered Lines: 2724
Relevant Lines: 3445
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9481723129

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 25 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-1.5%) to 78.897%
Files with Coverage Reduction New Missed Lines %
src/model.jl 1 88.35%
src/varinfo.jl 6 92.13%
src/simple_varinfo.jl 6 82.61%
src/threadsafe.jl 12 53.51%
Totals Coverage Status
Change from base Build 9387717755: -1.5%
Covered Lines: 2718
Relevant Lines: 3445
💛 - Coveralls

@github-actions GitHub Actions
Copy link
Contributor

Pull Request Test Coverage Report for Build 9481723129

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 25 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.02%) to 80.326%
Files with Coverage Reduction New Missed Lines %
src/model.jl 1 88.35%
src/varinfo.jl 6 92.13%
src/simple_varinfo.jl 6 82.61%
src/threadsafe.jl 12 53.51%
Totals Coverage Status
Change from base Build 9387717755: -0.02%
Covered Lines: 2756
Relevant Lines: 3431
💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Jun 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9481723129

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 25 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.02%) to 80.326%
Files with Coverage Reduction New Missed Lines %
src/model.jl 1 88.35%
src/varinfo.jl 6 92.13%
src/simple_varinfo.jl 6 82.61%
src/threadsafe.jl 12 53.51%
Totals Coverage Status
Change from base Build 9387717755: -0.02%
Covered Lines: 2756
Relevant Lines: 3431
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9481726759

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 80.326%
Totals Coverage Status
Change from base Build 9387717755: -0.02%
Covered Lines: 2756
Relevant Lines: 3431
💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9481726759

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 80.326%
Totals Coverage Status
Change from base Build 9387717755: -0.02%
Covered Lines: 2756
Relevant Lines: 3431
💛 - Coveralls

yebai
yebai approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@yebai yebai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @torfjelde -- it looks good.

@torfjelde torfjelde enabled auto-merge June 12, 2024 14:18
@yebai
Fix turing tests (#618)
96c0954 
* fix turing tests

* fix missing imports
@yebai yebai disabled auto-merge June 12, 2024 20:57
@yebai yebai merged commit c6f7198 into master Jun 12, 2024
10 of 11 checks passed
@yebai yebai deleted the torfjelde/kwargs-missing-fix branch June 12, 2024 20:57
@yebai
Copy link
Member

yebai commented Jun 12, 2024

Auto-merging is failing again -- I am merging manually since all tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yebai yebai yebai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@torfjelde @coveralls @yebai