Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Tapir extension to allow the reuse of rule #646

Closed
wants to merge 2 commits into from

Conversation

sunxd3
Copy link
Member

@sunxd3 sunxd3 commented Aug 23, 2024

@sunxd3 sunxd3 force-pushed the sunxd/tapir_extension branch from 0e53f1a to 8c19984 Compare August 23, 2024 10:04
@sunxd3
Copy link
Member Author

sunxd3 commented Aug 23, 2024

DynamicPPL still supports Julia 1.6, Tapir support 1.10 with the newest versions. Not sure what to do here...

@yebai
Copy link
Member

yebai commented Aug 23, 2024

The master branch of DynamicPPL contains unreleased breaking changes. For now, it is easier to open a PR against Tapir and transfer code there.

@coveralls
Copy link

coveralls commented Aug 23, 2024

Pull Request Test Coverage Report for Build 10523802467

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 29 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.1%) to 77.375%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/DynamicPPL.jl 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/model.jl 1 88.46%
src/logdensityfunction.jl 10 57.58%
src/threadsafe.jl 18 49.57%
Totals Coverage Status
Change from base Build 10487776343: -0.1%
Covered Lines: 2712
Relevant Lines: 3505

💛 - Coveralls

@sunxd3
Copy link
Member Author

sunxd3 commented Aug 23, 2024

closed in favor of compintell/Mooncake.jl#234

@sunxd3 sunxd3 closed this Aug 23, 2024
@yebai yebai deleted the sunxd/tapir_extension branch August 23, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants