Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Depreciate
@submodel l ~ m
in favour ofl ~ to_submodel(m)
; renamegenerated_quantities
toreturned
#696Depreciate
@submodel l ~ m
in favour ofl ~ to_submodel(m)
; renamegenerated_quantities
toreturned
#696Changes from 3 commits
5c746c4
0b081b7
dc699a5
7067695
8cb0796
2d887c9
692cfff
32fd6b9
5478fb3
5fe65b3
9e0730f
cc3af46
720053a
fe0403f
55b95a1
34fb6bd
9a7e18f
7aef65b
5ee727b
d92141c
64b519d
1b48f65
db2102c
da95aba
c8d567f
d477137
4896793
946fa6d
bf35de4
0f20624
99d99b3
0597b2a
0c6bada
5134ff7
45451f7
c00a9ae
f0af1d5
1b231a9
1faa627
92ac6b9
f73d1b0
b7b2e1d
ed4bb76
36f02f6
98538c5
d316306
0e05901
f073b25
2ec03c1
1f70dfc
f645259
23355ea
0e82a60
b9017c4
6e149a3
933e4ed
4fc7b76
b421687
c71242f
5c289c5
3c204d9
044f6c3
f716296
76aebc5
c150a87
b95e7d5
ecb4737
1e238ca
3525765
ed0cec3
13a2bf7
f94e07a
86d0e4c
d03eb4c
7c7ecc3
341b6b8
b467c75
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found
hard and unintuitive to parse. I think
would be much clearer. Not sure if this a documentation issue, or if we should disallow the former.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a documentation issue IMO, as this is not doing any special parsing but reliying on Julia's expression parsing.
Check warning on line 411 in src/submodel_macro.jl
Codecov / codecov/patch
src/submodel_macro.jl#L411