Remove selector stuff from VarInfo tests and link/invlink #780
+509
−405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12813097029Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 12932659074Details
💛 - Coveralls |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-0.35 #780 +/- ##
================================================
- Coverage 86.16% 85.53% -0.64%
================================================
Files 36 36
Lines 4301 4376 +75
================================================
+ Hits 3706 3743 +37
- Misses 595 633 +38 ☔ View full report in Codecov by Sentry. |
mhauru
changed the title
|
Sorry, spoke too soon. |
|
Okay, we are back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a part of moving away from using Selectors/Gibbs IDs/indexing by samplers. It does two things:
VarInfos by samplers intest/varinfo.jl.link,link!!,invlink, andinvlink!!to not take samplers as arguments anymore, but rather (iterables of)VarNames.These two changes were easiest to do at the same time, for reasons.
Note that more clean up Selector/Gibbs ID stuff is to come, but I'm asking for code review at this stage to avoid one megareview. This PR is not to be merged to
master, but rather to #779, which will collect all Selector-removal changes.