Add getparams and get_params_varinfo functions
#113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunxd3
changed the title
getparams and get_params_varinfo functiongetparams and get_params_varinfo functions
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #113 +/- ##
==========================================
+ Coverage 71.42% 72.16% +0.73%
==========================================
Files 16 16
Lines 1673 1692 +19
==========================================
+ Hits 1195 1221 +26
+ Misses 478 471 -7
☔ View full report in Codecov by Sentry. |
|
The HMC inference tests take too long now, I will find a way to make them faster and then enable them in CI (right now, I am running them locally before merging). The issue right now seems to be that I put the tests in separate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In light of TuringLang/Turing.jl#2097, we know sometimes computation with
ReverseDiffcompiled can be wrong becauseLogDensityProblemsADuses zeros array for the compilation process.This PR added a function
getparamssimilar toDynamicPPL.jl's.The PR also update the function
get_params_varinfoso that we can return a DPPL compatibleSimpleVarInfowith values in unconstrained space.