-
Notifications
You must be signed in to change notification settings - Fork 10
Support for Julia v1.12 #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Libtask.jl documentation for PR #196 is available at: |
The test suite now passes except for the test cases called |
These tests look slightly weird. They might be violating opaque closure assumptions, e.g. dynamic dispatch of |
This works, it doesn't answer why JuliaLang/julia#59222 fails, though. julia> g(xs::Tuple{Vararg{T}}) where T = 1
julia> (t::Tuple{typeof(g)})(xs::Tuple{Vararg{T}}) where T = t[1](xs)
julia> ir = Base.code_ircode_by_type(Tuple{Tuple{typeof(g)}, Tuple{Vararg{Symbol}}})[1][1]
julia> ir.argtypes[1] = Tuple{typeof(g)}
julia> oc = Core.OpaqueClosure(ir, g; isva=true, do_compile=true)
julia> oc(:a, :b) # works on 1.12 and 1.11 EDIT: I suspect that |
The case where this comes up is if, in a TapedTask, you have a dynamic call to a varargs function that might have a produce statement. In that case Your comment about the callable being in the captures is good though, because it made me realise that I don't need that to replicate the problem. This, too, segfaults: module MWE
g(xs...) = 1
ir = Base.code_ircode_by_type(Tuple{typeof(g), Symbol, Symbol})[1][1]
ir.argtypes[1] = Tuple{}
oc = Core.OpaqueClosure(ir; isva=true, do_compile=true)
oc(:a, :b) # segfault on 1.12
end |
Work in progress, though most tests now pass. Current known issues are calling varargs functions and and more allocations than on v1.11.