-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't get stuck in an infinite loop if HMC can't find an initial point #2392
Conversation
38af713
to
2212e11
Compare
3eef067
to
0b854bd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2392 +/- ##
==========================================
+ Coverage 76.81% 83.93% +7.12%
==========================================
Files 22 22
Lines 1570 1575 +5
==========================================
+ Hits 1206 1322 +116
+ Misses 364 253 -111 ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 11724704847Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @penelopeysm -- it looks good to me.
Also LGTM -- definitely a drastic improvement over hanging. |
eb46dcc
to
6fd59ac
Compare
Quick fix for #2389.
See also TuringLang/AdvancedHMC.jl#381 for added context.
Closes #2389