-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DynamicPPL integration tests #2393
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2393 +/- ##
==========================================
- Coverage 86.41% 86.28% -0.13%
==========================================
Files 22 22
Lines 1575 1575
==========================================
- Hits 1361 1359 -2
- Misses 214 216 +2 ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 12171154106Details
💛 - Coveralls |
9f8023c
to
1412416
Compare
Should be mergeable, I think, then I'll get rid of them from DynamicPPL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of these tests could deffo be moved to DynamicPPL.jl proper, but happy to merge them now if accompanied with an issue over at DPPL to ensure we don't loose track of the TODOs:)
Currently thinking it's more prudent to figure out how to move those tests into the DPPL test suite proper 😅 |
ee0e061
to
de0c54c
Compare
In line with the above, I'm going to close this PR and open a new one |
This PR adds the Turing/DynamicPPL integration tests (from the
test/turing
folder in DynamicPPL) to this repository instead.The main motivation behind this PR is to ensure that the tests added here are always run whenever a new version of Turing is released, thus making it impossible to release a version of Turing that contains a buggy version of DynamicPPL. See TuringLang/DynamicPPL.jl#703 for more thorough explanation.
Some implementation details:
link!(vi, sampler)
->link!!(vi, sampler, model)
; the same withinvlink!
; andAutoReverseDiff(false)
->AutoReverseDiff(; compile=false)
).Otherwise, this is a straight copy paste.