Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turing v0.36 and removal of Pathfinder code #579

Merged
merged 10 commits into from
Jan 28, 2025
Merged

Conversation

mhauru
Copy link
Member

@mhauru mhauru commented Jan 16, 2025

This PR makes two unrelated changes:

  1. It upgrades Turing to v0.36, and correspondingly updates instructions for how to use the Gibbs sampler.
  2. It removes the code example for how to use Pathfinder, and thus the docs environment's dependency on Pathfinder.

These are in the same PR, because doing the first one made us realise that having Pathfinder as dependency is annoying: We couldn't upgrade Turing.jl to v0.36 because there was not yet a version of Pathfinder that included it in its compat, and we thus couldn't build docs for the latest version of our own package.

@mhauru mhauru requested a review from penelopeysm January 16, 2025 16:51
@penelopeysm
Copy link
Member

Oh no, something about the new Gibbs is failing 😓

@penelopeysm penelopeysm force-pushed the mhauru/0.36-gibbs branch 2 times, most recently from 56b03a4 to 40ed08a Compare January 17, 2025 22:15
Copy link
Contributor

Preview the changes: https://turinglang.org/docs/pr-previews/579
Please avoid using the search feature and navigation bar in PR previews!

Copy link
Member

@penelopeysm penelopeysm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're happy I'm happy

@mhauru
Copy link
Member Author

mhauru commented Jan 28, 2025

Thanks for fixing this!

@mhauru mhauru merged commit 523428a into master Jan 28, 2025
2 checks passed
@mhauru mhauru deleted the mhauru/0.36-gibbs branch January 28, 2025 16:54
github-actions bot added a commit that referenced this pull request Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants