Enable back support for OpenAL #831
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mmm, the error in the CI is not linked to code compilation error or anything. It seems the CI is broken today :/
|
damiencarol
changed the title
|
@WALLOFJUSTICE it's complete now. we can review. |
damiencarol
changed the title
|
found a bug, switching it back to draft. |
|
Added better management when a music fail to load to prevent NPE |
damiencarol
changed the title
|
It builds successfully with -DFMOD_ENABLED=OFF -DOPENAL_ENABLED=1 libvorbis-dev and libopenal-dev installed but fails to complete the loading screen when launching barony. Output: So I tried copying an existing ogg vorbis audio file as "intro00.ogg" to no avail. The game data sold through GOG does not contain any such "intro00.ogg". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a few misalignment between the code for FMod and OpenAL.
The reason is that the FMod code changed a bit and the part that supports OpenAL was not modified.
What this PR do
Allows to compile with OpenAL and have sound/music support without any crashes (tested on Linux, test for Windows will come).
I'm trying to minimize the changes to have a digest PR, don't shoot me to not fix everything around sound/music :)
What I found:
#ifdef SOUNDwe need#ifdef MUSICStatus of tests:
✅ => I'm able to complete a game (gemili) by using most of the secret levels and play with sound levels in the settings
My first impression is that the OpenAL is more accurate/better, at least on Linux (OpenAL Soft implementation). The music are better when I compare with the version with FMod distributed with Steam, my reference.