-
-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(alerting): Added Incident.io alerting provider #972
base: master
Are you sure you want to change the base?
Conversation
@TwiN could you review the PR? |
Co-authored-by: Maksim Zhylinski <[email protected]>
Co-authored-by: Maksim Zhylinski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to implement the feature.
I left a few comments. They are all with the intent of improving the default UX of a Gatus user. Let me know what you think.
I'll look at this tomorrow and do some manual testing to see if there are issues (e.g. configure locally, run status, let it resolve alerts).
Co-authored-by: Julien Limoges <[email protected]>
Co-authored-by: Julien Limoges <[email protected]>
Co-authored-by: Julien Limoges <[email protected]>
Co-authored-by: Julien Limoges <[email protected]>
@limoges Thank you for helping with the review, it's strongly appreciated! |
… resolved-with-metadata-source-url test case.
@TwiN mind rechecking the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
Fixes #967
Checklist
README.md
, if applicable.