Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alerting): Add Incident.io alerting provider #972

Merged
merged 27 commits into from
Feb 7, 2025

Conversation

ImTheCurse
Copy link
Contributor

Summary

  • Added Incident.io as an alerting provider.
  • Added testing for Incident.io alerting provider.
  • Added documentation.

Fixes #967

Checklist

  • Tested and/or added tests to validate that the changes work as intended, if applicable.
  • Updated documentation in README.md, if applicable.

@ImTheCurse
Copy link
Contributor Author

@TwiN could you review the PR?

@ImTheCurse ImTheCurse changed the title feat(alerting): Added Incident.io provider feat(alerting): Added Incident.io alerting provider Jan 20, 2025
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
alerting/config.go Outdated Show resolved Hide resolved
@ImTheCurse ImTheCurse requested a review from TwiN January 21, 2025 07:17
README.md Outdated Show resolved Hide resolved
alerting/alert/type.go Outdated Show resolved Hide resolved
alerting/config.go Outdated Show resolved Hide resolved
ImTheCurse and others added 2 commits January 22, 2025 18:14
Co-authored-by: Maksim Zhylinski <[email protected]>
Co-authored-by: Maksim Zhylinski <[email protected]>
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@ImTheCurse ImTheCurse marked this pull request as draft January 22, 2025 17:46
Copy link
Contributor

@limoges limoges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to implement the feature.

I left a few comments. They are all with the intent of improving the default UX of a Gatus user. Let me know what you think.

I'll look at this tomorrow and do some manual testing to see if there are issues (e.g. configure locally, run status, let it resolve alerts).

@ImTheCurse
Copy link
Contributor Author

@TwiN mind rechecking the PR?

Copy link
Contributor

@limoges limoges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the source-url and metadata, I did a small manual test with a config and was able to validate the metadata/attributes and source-url.

This is what an alert looks like:
image

LGTM, I think this would deploy without issue for our usecase.

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 83.47826% with 19 lines in your changes missing coverage. Please review.

Project coverage is 75.91%. Comparing base (ea2b7c4) to head (6c516f9).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
alerting/provider/incidentio/incident_io.go 83.33% 13 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #972      +/-   ##
==========================================
+ Coverage   75.78%   75.91%   +0.12%     
==========================================
  Files          74       75       +1     
  Lines        6768     6883     +115     
==========================================
+ Hits         5129     5225      +96     
- Misses       1332     1345      +13     
- Partials      307      313       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

alerting/config.go Outdated Show resolved Hide resolved
@ImTheCurse
Copy link
Contributor Author

@TwiN Mind rechecking?

alerting/config.go Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
alerting/alert/type.go Outdated Show resolved Hide resolved
Copy link
Owner

@TwiN TwiN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there!

alerting/provider/provider.go Outdated Show resolved Hide resolved
@ImTheCurse ImTheCurse requested a review from TwiN February 7, 2025 00:12
@TwiN TwiN added feature New feature or request area/alerting Related to alerting labels Feb 7, 2025
@TwiN TwiN changed the title feat(alerting): Added Incident.io alerting provider feat(alerting): Add Incident.io alerting provider Feb 7, 2025
@TwiN TwiN merged commit 541a705 into TwiN:master Feb 7, 2025
2 checks passed
@TwiN
Copy link
Owner

TwiN commented Feb 7, 2025

@ImTheCurse Thank you for the contribution!

@ImTheCurse ImTheCurse deleted the feat-incident-io branch February 7, 2025 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/alerting Related to alerting feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Incident.io as Alerting provider
4 participants