Feat/reminder interval #614
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 5, 2023 08:38
This was referenced Mar 9, 2024
TwiN
requested changes
Apr 9, 2024
merou
approved these changes
Apr 30, 2024
|
I want this! |
|
Wow I'm really sorry for forgetting about this for so long! @bugrakocabay any chance you can resolve the conflict and ping me when it's done? I'll get this merged and released ASAP |
TwiN
requested changes
Dec 5, 2024
There was a problem hiding this comment.
Can this be renamed to MinimumRepeatInterval?
Because it doesn't necessarily happen every repeat interval given that the evaluation is driven by the normal interval. For instance, if the interval is set to 5m and the repeat interval is set to 7m, the alert would only be sent on the 2nd evaluation (so after 10m), not after the repeat interval of 7m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @TwiN
Summary
Regarding this issue #599.
Checklist
README.md, if applicable.