Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): external links #964

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Level8Broccoli
Copy link

Summary

Concerning: #106

Disclaimer: This is the first time I have worked with Go, also have not really experience with Tailwind, so this is just a first draft with probably a lot of room to improve. I am happy to keep working on it, if somebody directs me in the right direction.

Open tasks/questions

  • MenuItem.Type: is currently just a string. Is it possible (and also sensible) to have some kind of Enum in Go?
  • MenuItem: Is it possible to make all three fields mandatory?
  • MenuItem.Type = "text": What does the Value field represent?
  • I added the existing ui.Config to each status request. Does that make sense?

Checklist

  • Tested and/or added tests to validate that the changes work as intended, if applicable.
  • Updated documentation in README.md, if applicable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant