Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 99 - collapse filter v2 #242

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

amaxama
Copy link
Contributor

@amaxama amaxama commented Sep 11, 2020

What

Adding collapsibility to the top level filters and toggling a legend overlay on map when filters are collapsed

Why

Issue #99

Ensure the following interactions work as expected. Please test using a mobile form factor.

  • Tapping on a marker on the map displays information about the marker in a popup.
  • Tapping the "Show list of locations" button replaces the map view with a list view.
  • Tapping an item in the list replaces the list view with a map view, and navigates the map to the tapped item on the map.
  • Tapping one of the ✅'s in the legend filters items on the map and in the list.
  • Changing the language to spanish changes things on the page.
  • Clicking the Help/Info button opens and closes a menu with information.
  • Clicking the X Close button on the Help/Info screen closes the modal.

Check the app in the following web browsers:

  • Chrome
  • Firefox
  • Edge
  • Safari

@amaxama amaxama added the Status: DON'T MERGE YET Don't merge yet. Please :) label Sep 11, 2020
@@ -20,6 +20,7 @@
--primary-700: hsl(var(--primary), 35%);
--primary-800: hsl(var(--primary), 25%);
--primary-900: hsl(var(--primary), 15%);
--primary-blue: hsl(var(--primary), 10%);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the original dark blue used for the title header - open to a better variable name if there are suggestions!

}

.filter-pane {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved all legend and filter related items to filter.css

</div>
<div class="action-group">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of this is indentation changes

@@ -52,7 +52,7 @@ a.txt-white:hover {

.content {
z-index: 1;
width: 33.3333%;
width: 36%;
Copy link
Contributor Author

@amaxama amaxama Sep 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made just a little wider so title fits on one line more often

@amaxama amaxama added Type: Needs Translation There are new keys in this PR that require translation. and removed Status: DON'T MERGE YET Don't merge yet. Please :) labels Sep 13, 2020
@amaxama amaxama linked an issue Sep 22, 2020 that may be closed by this pull request
@amaxama amaxama removed the Type: Needs Translation There are new keys in this PR that require translation. label Oct 3, 2020
@amaxama
Copy link
Contributor Author

amaxama commented Oct 8, 2020

This is missing full-fledged Ojibwe, Dakota, and Hindi translations… the translations that are missing are shorter versions of our main filter items so what I did was just put in the translations we already have for for distributing for receiving open for both and not open now because whether its a short form or long, the meaning is the most important part and that’s all still reflected in the legend overlay with these long-form phrases. And then in place of Filter I just left it blank because as a user the dropdown starts as open and you don’t really need the explicit directions to filter (we don’t have it now on the current site). So I still have TODOs in the code to fill those in when we get them (and I could make a follow up story) but this is a temporary solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle filter collapsing in small screen (has design)
1 participant