Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TT-9291] Add extraVolume and extraVolumeMounts #638

Merged
merged 5 commits into from
Jul 13, 2023
Merged

[TT-9291] Add extraVolume and extraVolumeMounts #638

merged 5 commits into from
Jul 13, 2023

Conversation

buraksekili
Copy link
Member

@buraksekili buraksekili commented Jul 4, 2023 •
edited
Loading

Description

This PR adds options to add extra volume and volumeMounts to operator manager pod.
If your Tyk installation runs with self-signed certs, the required certs can be uploaded to Tyk Operator Pod via these new fields and Operator can interact with the Tyk installation

Related Issue

https://tyktech.atlassian.net/browse/TT-9291

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • Make sure you are updating CHANGELOG.md based on your changes.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • If you've changed API models, please update CRDs.
    • make manifests
    • make helm
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • gofmt -s -w .
    • go vet ./...
    • golangci-lint run

@buraksekili buraksekili marked this pull request as ready for review July 11, 2023 11:50
@buraksekili buraksekili requested a review from a team as a code owner July 11, 2023 11:50
@buraksekili buraksekili requested review from komalsukhani and removed request for a team July 11, 2023 11:50
@komalsukhani
Copy link
Collaborator

@buraksekili Looks great. Can you also update the changelog?

@sonarcloud
Copy link

sonarcloud bot commented Jul 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@singhpr singhpr merged commit ef3295c into master Jul 13, 2023
14 checks passed
@singhpr singhpr deleted the feature/TT-9291/tls-connection-custom-ca branch July 13, 2023 07:03
buger pushed a commit that referenced this pull request May 22, 2024
@buraksekili
[TT-9291] Add extraVolume and extraVolumeMounts (#638)
2692ac2 
* Add extra volume and volumeMounts to helm

Signed-off-by: Burak Sekili <[email protected]>

* add extraVolume and extraVolumeMounts options to helm

Signed-off-by: Burak Sekili <[email protected]>

* Fix indentation issue

Signed-off-by: Burak Sekili <[email protected]>

* Update CHANGELOG.md

---------

Signed-off-by: Burak Sekili <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@komalsukhani komalsukhani komalsukhani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@buraksekili @komalsukhani @singhpr