Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TT-9323] Improve policy reconcile #639

Merged
merged 7 commits into from
Jul 11, 2023
Merged

[TT-9323] Improve policy reconcile #639

merged 7 commits into from
Jul 11, 2023

Conversation

komalsukhani
Copy link
Collaborator

@komalsukhani komalsukhani commented Jul 5, 2023 •
edited by jira bot
Loading

Description

Fix function used to update status of api definition.

Related Issue

TT-9323

Motivation and Context

Getting below error while reconciling policy because status of api was updated multiple times in the function
the object has been modified; please apply your changes to the latest version and try again

Test Coverage For This Change

Added integration tests.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • Make sure you are updating CHANGELOG.md based on your changes.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • If you've changed API models, please update CRDs.
    • make manifests
    • make helm
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • gofmt -s -w .
    • go vet ./...
    • golangci-lint run

@komalsukhani komalsukhani marked this pull request as ready for review July 6, 2023 06:36
@komalsukhani komalsukhani requested a review from a team as a code owner July 6, 2023 06:36
@komalsukhani komalsukhani requested review from buraksekili and removed request for a team July 6, 2023 06:36
buraksekili
buraksekili reviewed Jul 10, 2023
View reviewed changes
Copy link
Member

@buraksekili buraksekili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks

@sonarcloud
Copy link

sonarcloud bot commented Jul 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@singhpr singhpr merged commit 2877569 into master Jul 11, 2023
14 checks passed
@singhpr singhpr deleted the fix/TT-9323/improve_policy_reconcile branch July 11, 2023 10:17
buger pushed a commit that referenced this pull request May 22, 2024
@komalsukhani
[TT-9323] Improve policy reconcile (#639)
1a97ec4 
* Do not reconcile policy on status update

* Fix logic to update status of api definitions

* Add tests

* Fix lint errors

* Update changelog

* Rename variables to avoid confusion

* Declare eval at the test function scope
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buraksekili buraksekili buraksekili approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@komalsukhani @buraksekili @singhpr