[TT-9438] Add an option to enable Prometheus ServiceMonitor for /metrics endpoint
#641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Burak Sekili <[email protected]>
Signed-off-by: Burak Sekili <[email protected]>
caroltyk
changed the title
/metrics endpoint/metrics endpoint
caroltyk
changed the title
/metrics endpoint/metrics endpoint
andrei-tyk
approved these changes
Jul 13, 2023
buraksekili
changed the title
/metrics endpoint/metrics endpoint
|
Kudos, SonarCloud Quality Gate passed!
|
buger
pushed a commit
that referenced
this pull request
May 22, 2024
…rics` endpoint (#641) * Add an option to enable prometheus servicemonitor for /metrics endpoint Signed-off-by: Burak Sekili <[email protected]> * Add an entry to CHANGELOG Signed-off-by: Burak Sekili <[email protected]> --------- Signed-off-by: Burak Sekili <[email protected]> Co-authored-by: Pranshu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
.Values.serviceMonitoroption to helm chart in order ServiceMonitor to be enabled.Related Issue
https://tyktech.atlassian.net/browse/TT-9438
Motivation and Context
Test Coverage For This Change
Screenshots (if appropriate)
Types of changes
Checklist
master!masterbranch (left side). Also, it would be best if you started your change off our latestmaster.make manifestsmake helmgofmt -s -w .go vet ./...golangci-lint run