Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TT-10630] Upgrade Go version to 1.21 #665

Merged
merged 6 commits into from
Dec 20, 2023
Merged

[TT-10630] Upgrade Go version to 1.21 #665

merged 6 commits into from
Dec 20, 2023

Conversation

buraksekili
Copy link
Member

Description

This PR updates go version to 1.21

Related Issue

https://tyktech.atlassian.net/browse/TT-10630

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • Make sure you are updating CHANGELOG.md based on your changes.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • If you've changed API models, please update CRDs.
    • make manifests
    • make helm
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • gofmt -s -w .
    • go vet ./...
    • golangci-lint run

@buraksekili
upgrade go version to 1.21
675423f 
Signed-off-by: Burak Sekili <[email protected]>
@buraksekili buraksekili requested a review from a team as a code owner December 8, 2023 11:42
@buraksekili buraksekili requested review from andrei-tyk and removed request for a team December 8, 2023 11:42
@sweep-ai Sweep AI
Copy link

sweep-ai bot commented Dec 8, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 20, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@singhpr singhpr merged commit 12b17db into master Dec 20, 2023
16 checks passed
@singhpr singhpr deleted the update/go-version branch December 20, 2023 09:11
buger pushed a commit that referenced this pull request May 22, 2024
@buraksekili @singhpr
[TT-10630] Upgrade Go version to 1.21 (#665)
e51f2ca 
* upgrade go version to 1.21

Signed-off-by: Burak Sekili <[email protected]>

* use copy of the tc in order to prevent running range variables in the func literals

Signed-off-by: Burak Sekili <[email protected]>

* update golangci lint version

Signed-off-by: Burak Sekili <[email protected]>

---------

Signed-off-by: Burak Sekili <[email protected]>
Co-authored-by: Pranshu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@komalsukhani komalsukhani komalsukhani approved these changes

@andrei-tyk andrei-tyk Awaiting requested review from andrei-tyk andrei-tyk is a code owner automatically assigned from TykTechnologies/operator-squad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@buraksekili @komalsukhani @singhpr