Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tyk version matrix #673

Merged
merged 7 commits into from
Jan 12, 2024
Merged

Update tyk version matrix #673

merged 7 commits into from
Jan 12, 2024

Conversation

komalsukhani
Copy link
Collaborator

@komalsukhani komalsukhani commented Jan 10, 2024 •
edited
Loading

Description

Update tyk version matrix used for testing operator.

Related Issue

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • Make sure you are updating CHANGELOG.md based on your changes.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • If you've changed API models, please update CRDs.
    • make manifests
    • make helm
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • gofmt -s -w .
    • go vet ./...
    • golangci-lint run

@sweep-ai Sweep AI
Copy link

sweep-ai bot commented Jan 10, 2024

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@sweep-ai Sweep AI
Copy link

sweep-ai bot commented Jan 10, 2024 •
edited
Loading

Sweeping

Fixing PR: track the progress here.

I'm currently fixing this PR to address the following:

[Sweep GHA Fix] The GitHub Actions run failed with the following error logs:

[!CAUTION]

An error has occurred: Sweep could not find any files to modify (tracking ID: f43fcdc1c1)

@komalsukhani komalsukhani marked this pull request as ready for review January 11, 2024 11:22
@komalsukhani komalsukhani requested a review from a team as a code owner January 11, 2024 11:22
@komalsukhani komalsukhani requested review from buraksekili and olamilekan000 and removed request for a team January 11, 2024 11:22
@komalsukhani komalsukhani changed the title Update run_tests.yaml Update tyk version matrix Jan 11, 2024
@buraksekili buraksekili changed the base branch from master to fix/TT-10958/policy-oss January 12, 2024 07:17
@buraksekili buraksekili merged commit 95eb434 into fix/TT-10958/policy-oss Jan 12, 2024
1 check passed
singhpr added a commit that referenced this pull request Jan 12, 2024
@buraksekili @komalsukhani @singhpr
[TT-10958] Do not modify MID of Security Policy in OSS (#675)
5a33c2e 
* Do not modify MID of Security Policy in OSS

Signed-off-by: Burak Sekili <[email protected]>

* Check for ID in OSS instead of MID

Signed-off-by: Burak Sekili <[email protected]>

* Check tyk mode while validation status

Signed-off-by: Burak Sekili <[email protected]>

* Update changelog

Signed-off-by: Burak Sekili <[email protected]>

* Update tyk version matrix (#673)

* Update run_tests.yaml

* Update run_tests.yaml

* Update run_tests.yaml

* Update run_tests.yaml

* Update run_tests.yaml

---------

Signed-off-by: Burak Sekili <[email protected]>
Co-authored-by: Komal Sukhani <[email protected]>
Co-authored-by: Pranshu <[email protected]>
buger pushed a commit that referenced this pull request May 22, 2024
@buraksekili @komalsukhani @singhpr
[TT-10958] Do not modify MID of Security Policy in OSS (#675)
145a26c 
* Do not modify MID of Security Policy in OSS

Signed-off-by: Burak Sekili <[email protected]>

* Check for ID in OSS instead of MID

Signed-off-by: Burak Sekili <[email protected]>

* Check tyk mode while validation status

Signed-off-by: Burak Sekili <[email protected]>

* Update changelog

Signed-off-by: Burak Sekili <[email protected]>

* Update tyk version matrix (#673)

* Update run_tests.yaml

* Update run_tests.yaml

* Update run_tests.yaml

* Update run_tests.yaml

* Update run_tests.yaml

---------

Signed-off-by: Burak Sekili <[email protected]>
Co-authored-by: Komal Sukhani <[email protected]>
Co-authored-by: Pranshu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buraksekili buraksekili buraksekili approved these changes

@olamilekan000 olamilekan000 Awaiting requested review from olamilekan000

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@komalsukhani @buraksekili