This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
[TT-10958] Do not modify MID of Security Policy in OSS #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Burak Sekili <[email protected]>
Signed-off-by: Burak Sekili <[email protected]>
Signed-off-by: Burak Sekili <[email protected]>
buraksekili
changed the title
buraksekili
requested review from
komalsukhani
and removed request for
a team
Signed-off-by: Burak Sekili <[email protected]>
komalsukhani
approved these changes
Jan 12, 2024
* Update run_tests.yaml * Update run_tests.yaml * Update run_tests.yaml * Update run_tests.yaml * Update run_tests.yaml
|
buger
pushed a commit
that referenced
this pull request
May 22, 2024
* Do not modify MID of Security Policy in OSS Signed-off-by: Burak Sekili <[email protected]> * Check for ID in OSS instead of MID Signed-off-by: Burak Sekili <[email protected]> * Check tyk mode while validation status Signed-off-by: Burak Sekili <[email protected]> * Update changelog Signed-off-by: Burak Sekili <[email protected]> * Update tyk version matrix (#673) * Update run_tests.yaml * Update run_tests.yaml * Update run_tests.yaml * Update run_tests.yaml * Update run_tests.yaml --------- Signed-off-by: Burak Sekili <[email protected]> Co-authored-by: Komal Sukhani <[email protected]> Co-authored-by: Pranshu <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates how securitypolicy controller handles MID field. Now, if tyk runs in CE mode (OSS), controller won't update MID field.
Related Issue
https://tyktech.atlassian.net/browse/TT-10958
Resolves #672
Motivation and Context
Test Coverage For This Change
Screenshots (if appropriate)
Types of changes
Checklist
master!masterbranch (left side). Also, it would be best if you started your change off our latestmaster.make manifestsmake helmgofmt -s -w .go vet ./...golangci-lint run