Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

TT-12519, added new versiondefinition fields #720

Closed
wants to merge 2 commits into from

Conversation

andrei-tyk
Copy link
Collaborator

Description

Related Issue

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • Make sure you are updating CHANGELOG.md based on your changes.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • If you've changed API models, please update CRDs.
    • make manifests
    • make helm
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • gofmt -s -w .
    • go vet ./...
    • golangci-lint run

@andrei-tyk andrei-tyk requested a review from a team as a code owner July 11, 2024 11:51
@andrei-tyk andrei-tyk requested review from komalsukhani and removed request for a team July 11, 2024 11:51
@komalsukhani komalsukhani deleted the TT-12519-url-versioning-regex branch October 10, 2024 14:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants