Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(TU-20040): Add isClosed to onReady callback payload #670

Merged
merged 1 commit into from
Nov 26, 2024
Merged

feat(TU-20040): Add isClosed to onReady callback payload #670

merged 1 commit into from
Nov 26, 2024

Conversation

mathio
Copy link
Contributor

@mathio mathio commented Nov 25, 2024

Resolves #647

@bender-bot-tf
Copy link

bender-bot-tf bot commented Nov 25, 2024

The main codeowner in the CODEOWNERS file of this repository is not a valid Typeform team, it is critical for many metrics at Typeform to comply with this standard.
More info: https://www.notion.so/typeform/CODEOWNERS-679209781dfa486295279039d38ff225
If you have any doubts please contact #app-infra-team.

@gitstream-cm gitStream.cm
Copy link

gitstream-cm bot commented Nov 25, 2024

🥷 Code experts: gierlas

gierlas has most 👩‍💻 activity in the files.
mathio has most 🧠 knowledge in the files.

See details

docs/callbacks.md

Activity based on git-commit:

gierlas
NOV
OCT
SEP
AUG 32 additions & 0 deletions
JUL
JUN

Knowledge based on git-blame:
mathio: 89%

packages/embed/README.md

Activity based on git-commit:

gierlas
NOV
OCT
SEP
AUG 6 additions & 0 deletions
JUL
JUN

Knowledge based on git-blame:
mathio: 96%

packages/embed/src/base/actionable-options.ts

Activity based on git-commit:

gierlas
NOV
OCT
SEP
AUG 7 additions & 0 deletions
JUL
JUN

Knowledge based on git-blame:
mathio: 59%

To learn more about /:\ gitStream - Visit our Docs

@mathio mathio mentioned this pull request Nov 25, 2024
Closed
@mathio mathio requested review from Thr44, robespmun and a team November 25, 2024 14:28
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
24 New issues
0 Accepted issues

Measures
0 Security Hotspots
65.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@typeform-ops-gha
Copy link

[BOT] Preview available with hash 85c4bbf14d55cc4100ff3dd4aef3fecf5cff7f9b here.

@mathio mathio merged commit f263f9e into main Nov 26, 2024
17 checks passed
@mathio mathio deleted the tu20040 branch November 26, 2024 14:29
typeform-ops-gha pushed a commit that referenced this pull request Jan 8, 2025
@semantic-release-bot
chore(release): 5.3.0 [skip ci]
d41fdc4 
# [@typeform/embed-v5.3.0](https://github.com/Typeform/embed/compare/@typeform/embed-v5.2.0...@typeform/embed-v5.3.0) (2025-01-08)

### Bug Fixes

* **TU-21474:** Remove overflow on widget close ([#677](#677)) ([ee4ddf6](ee4ddf6))

### Features

* **TU-20040:** Add `isClosed` to `onReady` callback payload ([#670](#670)) ([f263f9e](f263f9e)), closes [#647](#647)
@typeform-ops-gha
Copy link

🎉 This PR is included in version @typeform/embed-v5.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thr44 Thr44 Thr44 approved these changes

@joycevherck joycevherck joycevherck approved these changes

@robespmun robespmun Awaiting requested review from robespmun

Assignees
No one assigned
Labels
1 min review released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] A way to know if an embedded typeform is over quota and "closed"
4 participants
@mathio @typeform-ops-gha @Thr44 @joycevherck