Add Video Panning Option #150
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crosshair drawing is broken when videoAr != displayAr
I'm not sure about that scale_factor, i don't know how to test that
with a "good enough" implementation
The preview window would change in width, when the video was being zoomed. Possibly, because on windows, zooming only calls UpdateSize once, but on linux, it gets called multiple, like 8 times. Rounding fixed it.
I'm not entirely sure, that this is how it's supposed to be added. This requires editing the already existing hotkey.json file (shows path in log, if it exists). Should this also be added to hotkey.cpp?
This reverts commit 3d525d9. The default hotkey is not required. People can just add a custom one from the hotkey settings if they want this.
|
Fantastic feature! Thank you for adding it! Hoping this gets merged soon. |
|
This works great for me, although I noticed that the |
|
Also, I saw now that this change breaks Aegisub's aspect ratio forcing. I fixed it here on my fork, but as it is, this PR would just make the aspect ratio options do nothing at all. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ristellise/AegisubDC has closed its doors, and with such one of the most important features, the option to zoom in and do stuff. There is also currently no way to do this on Linux/MacOS, so this should make it available.
Patched from Aegisub#207 with snippets from DC.
Tested on Arch Linux, but should work wherever.
video_panning_example.mp4